Skip to content

test: increase timeout for flaky keepAlive test on Windows#434

Merged
TooTallNate merged 3 commits into
mainfrom
fix/keepalive-test-timeout
May 24, 2026
Merged

test: increase timeout for flaky keepAlive test on Windows#434
TooTallNate merged 3 commits into
mainfrom
fix/keepalive-test-timeout

Conversation

@clutz-bot
Copy link
Copy Markdown
Contributor

@clutz-bot clutz-bot Bot commented May 24, 2026

The should work with keepAlive: true test in proxy-agent intermittently times out on Windows CI. The default 10s timeout is too tight — the socket free event can be slow on Windows runners.

Bumps the timeout to 30s for just this test.

The 'should work with keepAlive: true' test in proxy-agent intermittently
times out on Windows CI (10s default). The socket 'free' event can be
slow on Windows. Bump to 30s for this specific test.
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 24, 2026

⚠️ No Changeset found

Latest commit: a8f8234

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@clutz-bot
Copy link
Copy Markdown
Contributor Author

clutz-bot Bot commented May 24, 2026

CI lint failure is due to a Prettier formatting issue in packages/proxy-agent/test/test.ts. I can't push a fix because proxy-agents isn't in my GitHub App installation. To fix: run npx prettier --write packages/proxy-agent/test/test.ts and push.

@TooTallNate TooTallNate merged commit b7e5f7c into main May 24, 2026
11 checks passed
@TooTallNate TooTallNate deleted the fix/keepalive-test-timeout branch May 24, 2026 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant