3 Bugfixes (#25)

* 3 Bugfixes

Fixed:
#24 -> Mapping checks for person now
#23  -> Removed Auditlogs in update when there are no changes
#21 -> Edited currentaccount to value in outputdata

* Processed feedback

Return null email on delete
Revert changes done to create. Currentaccount retrieves 'medewerker', not the account so Currentaccount.personid should work.

Author: rscholtelubberink

fieldMapping.json

@@ -324,7 +324,7 @@
             "Delete"
           ],
           "MappingMode": "Complex",
-          "Value": "\"function getEmail() {\\r\\n    let domain = '@enjoy.com';\\r\\n    let email = 'unknown' + domain;\\r\\n\\r\\n    if (typeof Person.Contact.Personal.Email !== 'undefined' && Person.Contact.Personal.Email) {\\r\\n        email = Person.Contact.Personal.Email;\\r\\n    }\\r\\n    else if (typeof Person.ExternalId !== 'undefined' && Person.ExternalId) {\\r\\n        email = Person.ExternalId;\\r\\n        email = email + domain;\\r\\n    }\\r\\n    return email;\\r\\n}\\r\\n\\r\\ngetEmail();\"",
+          "Value": "\"function getEmail() {\\r\\n    return null;\\r\\n}\\r\\n\\r\\ngetEmail();\"",
           "UsedInNotifications": false,
           "StoreInAccountData": false
         }

update.ps1

@@ -425,18 +425,6 @@ try {
             }
             'NoChanges' {
                 Write-Verbose "No changes needed for AFAS user [$($currentAccount.Gebruiker)]"
-
-                if (-Not($actionContext.DryRun -eq $true)) {
-                    $outputContext.AuditLogs.Add([PSCustomObject]@{
-                            Action  = "UpdateAccount"
-                            Message = "No changes needed for AFAS user [$($currentAccount.Gebruiker)]"
-                            IsError = $false
-                        })
-                }
-                else {
-                    Write-Warning "DryRun: No changes needed for AFAS user [$($currentAccount.Gebruiker)]"
-                }
-
                 break
             }
         }