Fix crash in cleanup command

Jimmacle · Jimmacle · commit 679a19e17f43 · 2017-07-26T00:13:22.000-07:00
diff --git a/Essentials/Commands/CleanupModule.cs b/Essentials/Commands/CleanupModule.cs
@@ -32,12 +32,15 @@ public void Delete()
             Context.Respond($"Deleted {count} grids matching the given conditions.");
         }
 
-        private IEnumerable<MyCubeGrid> ScanConditions(List<string> args)
+        private IEnumerable<MyCubeGrid> ScanConditions(IReadOnlyList<string> args)
         {
             var conditions = new List<Func<MyCubeGrid, bool>>();
 
             for (var i = 0; i < args.Count; i += 2)
             {
+                if (i + 1 > args.Count)
+                    break;
+
                 var arg = args[i];
                 var parameter = args[i + 1];
 
diff --git a/Essentials/Essentials.csproj b/Essentials/Essentials.csproj
@@ -135,11 +135,9 @@
     <Compile Include="AutoCommand.cs" />
     <Compile Include="Commands\BlocksModule.cs" />
     <Compile Include="Commands\CleanupModule.cs" />
-    <Compile Include="Commands\ScanModule.cs" />
     <Compile Include="Commands\VoxelModule.cs" />
     <Compile Include="Commands\WorldModule.cs" />
     <Compile Include="EssentialsConfig.cs" />
-    <Compile Include="Commands\DeleteModule.cs" />
     <Compile Include="Commands\EntityModule.cs" />
     <Compile Include="EssentialsControl.xaml.cs">
       <DependentUpon>EssentialsControl.xaml</DependentUpon>

Original file line number	Diff line number	Diff line change
`@@ -32,12 +32,15 @@ public void Delete()`
`32`	`32`	`Context.Respond($"Deleted {count} grids matching the given conditions.");`
`33`	`33`	`}`
`34`	`34`
`35`		`- private IEnumerable<MyCubeGrid> ScanConditions(List<string> args)`
	`35`	`+ private IEnumerable<MyCubeGrid> ScanConditions(IReadOnlyList<string> args)`
`36`	`36`	`{`
`37`	`37`	`var conditions = new List<Func<MyCubeGrid, bool>>();`
`38`	`38`
`39`	`39`	`for (var i = 0; i < args.Count; i += 2)`
`40`	`40`	`{`
	`41`	`+ if (i + 1 > args.Count)`
	`42`	`+ break;`
	`43`	`+`
`41`	`44`	`var arg = args[i];`
`42`	`45`	`var parameter = args[i + 1];`
`43`	`46`