adress https://github.com/TorqueGameEngines/Torque3D/issues/97#1723
Open
Azaezel wants to merge 2 commits intoTorqueGameEngines:developmentfrom
Open
adress https://github.com/TorqueGameEngines/Torque3D/issues/97#1723Azaezel wants to merge 2 commits intoTorqueGameEngines:developmentfrom
Azaezel wants to merge 2 commits intoTorqueGameEngines:developmentfrom
Conversation
this laregly occured due to adding ribbon nodes in smaller increments than the size of a given quad. we therefore skip adding new ribbon nodes if velocity, as determined by the point deltas, would be below 10% of the largest scale a given quad for that link in the ribbon would be. as this will result in lower than a max length ribbon, also adds a timeout mechanism of removing a link every TickMS (32 ticks/second, or roughly how often one would also be aded when in a growth state) for full finalization do still need to circle back and adress why there remains 1 quad spawned after motion.
…'t fix the last quad emission issue, and it actively fights designer values
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this laregly occured due to adding ribbon nodes in smaller increments than the size of a given quad. we therefore skip adding new ribbon nodes if velocity, as determined by the point deltas, would be below 10% of the largest scale a given quad for that link in the ribbon would be. as this will result in lower than a max length ribbon, also adds a timeout mechanism of removing a link every TickMS (32 ticks/second, or roughly how often one would also be aded when in a growth state) for full finalization do still need to circle back and adress why there remains 1 quad spawned after motion.