Skip to content

Script Fix for Parent call that does not use %this #1752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Azaezel merged 1 commit into from
May 31, 2026
Merged

Script Fix for Parent call that does not use %this #1752

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 16 additions & 4 deletions Engine/source/console/torquescript/compiledEval.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1981,10 +1981,22 @@ Con::EvalResult CodeBlock::exec(U32 ip, const char* functionName, Namespace* thi
}
else // it's a ParentCall
{
ConsoleValue& simObjectLookupValue = callArgv[1];
thisObject = getThisObject(simObjectLookupValue);
if (callArgc > 1)
{
ConsoleValue& simObjectLookupValue = callArgv[1];
thisObject = getThisObject(simObjectLookupValue);
}

if (thisObject == NULL)
// The grammar does NOT prepend anything. callArgv[1] is either
// a plain script argument (Parent::func(%arg)) or an explicitly
// passed %this (Parent::method(%this, %arg)) — the programmer's
// choice. For plain function parent calls callArgv[1] is never
// an object, so getThisObject returning NULL is expected and
// correct, not an error condition. The old guard was aborting
// these calls with a misleading "unable to find object" error
// using the value of %arg as the object name.

/*if (thisObject == NULL)
{
Con::warnf(
ConsoleLogEntry::General,
Expand All @@ -1998,7 +2010,7 @@ Con::EvalResult CodeBlock::exec(U32 ip, const char* functionName, Namespace* thi
stack[_STK + 1].setEmptyString();
_STK++;
break;
}
}*/

if (thisNamespace)
{
Expand Down
Loading