Assimp Animation fixes#1778
Open
marauder2k7 wants to merge 3 commits into
Open
Conversation
allow named actions with multiple nodes (similar to ambient including everything except each authored action should only have 1 track (channel) for each node already)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously our import logic for animations was broken, it imported a flat list of all nodes for each animation and applied them all to 1 sequence (ambient)
The issue with this is that multiple animations/actions could be referencing the same node and so if you exported with nla strips or actions in blender this would import the animations as 1 flat list and would break all animations that you required.
Now we seperate these channels out to their node name and match each action to 1 node if explicit. And then we import these seperately we also build the ambient animation from this list too so you get 1 complete timeline of all animations correctly setup.
Tested on FBX and GLTF
GLTF animations were importing incorrectly as we assumed CustomFrameRate also worked for gltf but this may be fbx only. Now our framerate defaults to 30fps and so on import the frames have the correct timing. Also our timing was guessing that this framearate was in ticks but instead it was in seconds for gltf. More formats may need to revisit this but hey its a good start.