Don't put the ABS token in download URLs#1565
Open
matalvernaz wants to merge 1 commit into
Open
Conversation
Send the bearer through the Authorization header instead. Background URLSession serializes task URLs to disk and query strings end up in proxy/CDN access logs, so a token in the URL leaks. The download endpoint already accepts Authorization: Bearer like every other authenticated call in this service.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Download URLs for Audiobookshelf carry the api token as a query param. Background URLSession writes task URLs to disk, and query strings end up in proxy and CDN logs, so the token leaks. Switched it to the Authorization header, which the download endpoint already accepts like every other call in the service.