Skip to content

Don't put the ABS token in download URLs #1565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
matalvernaz wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Don't put the ABS token in download URLs #1565

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions BookPlayer/AudiobookShelf/Network/AudiobookShelfConnectionService.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -521,22 +521,28 @@ class AudiobookShelfConnectionService: BPLogger {
throw URLError(.userAuthenticationRequired)
}

// The token is deliberately not appended as a query parameter. ABS accepts
// the bearer via `Authorization: Bearer` on this endpoint, and a token-bearing
// URL leaks: background URLSession serializes task URLs to disk, and query
// strings land in proxy/CDN access logs (Authorization headers don't).
return connection.url
.appendingPathComponent("api")
.appendingPathComponent("items")
.appendingPathComponent(item.id)
.appendingPathComponent("download")
.appending(queryItems: [URLQueryItem(name: "token", value: connection.apiToken)])
}

/// Returns a URLRequest for downloading a library item, carrying the user-defined
/// Returns a URLRequest for downloading a library item, carrying the bearer
/// token via the standard `Authorization: Bearer` header plus the user-defined
/// custom HTTP headers (needed for servers behind Cloudflare Access etc.).
public func createItemDownloadRequest(_ item: AudiobookShelfLibraryItem) throws -> URLRequest {
guard connection != nil else {
guard let connection else {
throw URLError(.userAuthenticationRequired)
}
let url = try createItemDownloadUrl(item)
return wrapWithCustomHeaders(url)
var request = wrapWithCustomHeaders(url)
applyAuthenticatedHeaders(to: &request, connection: connection)
return request
}

/// Wraps an arbitrary URL (e.g. a cover image or stream URL) in a URLRequest that carries
Expand Down
Loading