Ensure hooks are triggering in priority order

Author: linuxdaemon

CHANGELOG.md

@@ -30,6 +30,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - Fix FML random URL
 - Update tvdb.py to v3 TVDB API
 - Fix channel parameter handling in IRC client
+- Ensure hooks are triggered according to priority
 ### Removed
 - twitch.py removed due to outdated API and lack of maintainer
 - metacritic.py removed due to broken scraper and lack of maintainer

cloudbot/bot.py

@@ -322,8 +322,7 @@ def add_hook(hook, _event):
             if hook.clients and _event.conn.type not in hook.clients:
                 return True
 
-            coro = self.plugin_manager.launch(hook, _event)
-            tasks.append(coro)
+            tasks.append((hook, _event))
 
             if hook.action is Action.HALTALL:
                 halted = True
@@ -417,5 +416,10 @@ def add_hook(hook, _event):
                         # The hook has an action of Action.HALT* so stop adding new tasks
                         break
 
+        tasks.sort(key=lambda t: t[0].priority)
+
         # Run the tasks
-        await asyncio.gather(*tasks, loop=self.loop)
+        await asyncio.gather(*[
+            asyncio.ensure_future(self.plugin_manager.launch(hook, _event))
+            for hook, _event in tasks
+        ], loop=self.loop)