Drop 22.04 support entirely#1883
Merged
palfrey merged 1 commit intoTraceMachina:mainfrom Oct 13, 2025
Merged
Conversation
e86518b to
3214b71
Compare
3214b71 to
cf68190
Compare
MarcusSorealheis
requested changes
Jul 29, 2025
Collaborator
MarcusSorealheis
left a comment
There was a problem hiding this comment.
We already have so many tests. I want to deprecate and eventually remove one of the Mac versions, for instance. I think we should first conduct an inventory of what we need versus what we don't need.
Right now, the whole pipeline s too slow.
cf68190 to
9762d33
Compare
Member
Author
I've removed the 22.04 support entirely, as 24.04 is enough I'd say. |
9762d33 to
75099e5
Compare
palfrey
commented
Oct 13, 2025
|
|
||
| # hadolint ignore=DL3003 | ||
| RUN git clone https://github.com/blakehatch/drake.git && \ | ||
| RUN git clone https://github.com/RobotLocomotion/drake.git && \ |
Member
Author
There was a problem hiding this comment.
blakehatch version is very out of date and doesn't build with 24.04
MarcusSorealheis
approved these changes
Oct 13, 2025
MarcusSorealheis
pushed a commit
to MarcusSorealheis/nativelink
that referenced
this pull request
Nov 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As noted in #1882, we don't test 22.04 and we have specific package versions locked down. This will break when a new patch version of Ubuntu or the packages comes out and we don't test it. This PR drops 22.04 support entirely (although we probably still build just fine on it, we're just not checking it) and locks down 24.04 to a very specific revision
Type of change
Please delete options that aren't relevant.
How Has This Been Tested?
I've built all of the Dockerfile's I've changed by hand and made sure they still work and have corrected package versions.
Checklist
bazel test //...passes locallygit amendsee some docsThis change is