Skip to content

Astro 6#2328

Closed
palfrey wants to merge 7 commits into
TraceMachina:mainfrom
palfrey:astro-6
Closed

Astro 6#2328
palfrey wants to merge 7 commits into
TraceMachina:mainfrom
palfrey:astro-6

Conversation

@palfrey

@palfrey palfrey commented May 13, 2026

Copy link
Copy Markdown
Member

Description

Upgrades Astro to v6 and related package changes. Continues #2226 because merging that branch broke Deno in some way, so https://nativelink.com/ started doing 504's.

Type of change

Please delete options that aren't relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Manually, CI

Checklist

  • Updated documentation if needed
  • Tests added/amended
  • bazel test //... passes locally
  • PR is contained in a single commit, using git amend see some docs

This change is Reviewable

@thejackshelton

thejackshelton commented May 13, 2026

Copy link
Copy Markdown

Hey @palfrey, as a heads up I've been working on a rewrite of Qwik's bundler (in a relatively good state), but this requires Astro to release vite 8 and rolldown support for it to be used. I do believe this will lead to native deno support if it is not supported already or if you are having any current incompatibility issues.

@palfrey

palfrey commented May 20, 2026

Copy link
Copy Markdown
Member Author

Hey @palfrey, as a heads up I've been working on a rewrite of Qwik's bundler (in a relatively good state), but this requires Astro to release vite 8 and rolldown support for it to be used. I do believe this will lead to native deno support if it is not supported already or if you are having any current incompatibility issues.

I'm still seeing
[WARN] [vite] node_modules/@deno/astro-adapter/src/server.ts (108:12): "start" is not exported by "virtual:@deno/astro-adapter:config", imported by "node_modules/@deno/astro-adapter/src/server.ts".
in the logs, which I suspect is the source of the broken deploy issues. Tried upgrading @deno/astro-adapter to 0.5.1, still no luck there.

Also Qwik core bundle not found, is Qwik actually used in this project? which is a fun one.

@MarcusSorealheis

Copy link
Copy Markdown
Member

this is a time suck. We are going to drop this website in favor of a new version.

@thejackshelton

thejackshelton commented May 21, 2026

Copy link
Copy Markdown

Also Qwik core bundle not found, is Qwik actually used in this project? which is a fun one.

This is not actually true. It's an assumption from the current qwik vite plugin that both builds happen in an expected order, which in the Astro integration the order is a bit different than expected due to the way that Astro currently expects the build.

As for the bundler rewrite, I have released its first version under qwik-bundler

https://github.com/thejackshelton/qwik-bundler/tree/main/fixtures

Here is the list of available fixtures. This even includes native deno support without any node compatibility using vite environments!

Unfortunately, I think the blocker here is on the Astro side. I cannot update the Qwik integration for Astro until the next major release where rolldown and vite 8 is supported. Unsure of the Deno adapter support for Astro.

@MarcusSorealheis

MarcusSorealheis commented Jun 7, 2026

Copy link
Copy Markdown
Member

@thejackshelton we went in a different direction but we enjoyed using the project. We appreciate you for all the hard work and attentiveness.

@thejackshelton

Copy link
Copy Markdown

Thank you! I look forward to seeing NativeLink evolve and happy I could be a part of the journey (even if it was short 🙂 )

@MarcusSorealheis

MarcusSorealheis commented Jun 7, 2026 via email

Copy link
Copy Markdown
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants