Skip to content

Fix package artifact spec on Windows #563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
luokerenx4 merged 1 commit into from
Jul 12, 2026
+4 −3
Merged

Fix package artifact spec on Windows #563

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions scripts/desktop-package-artifact.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { existsSync, mkdirSync, writeFileSync } from 'node:fs'
import { mkdtemp, rm } from 'node:fs/promises'
import { tmpdir } from 'node:os'
import { join } from 'node:path'
import { join, resolve } from 'node:path'
import { afterEach, describe, expect, it } from 'vitest'

import {
Expand All @@ -21,8 +21,9 @@ afterEach(async () => {
describe('temporary desktop package ownership', () => {
it('uses the persistent package root unless an explicit root is supplied', () => {
expect(resolveDesktopPackageRootArg([])).toBe(DEFAULT_DESKTOP_PACKAGE_ROOT)
expect(resolveDesktopPackageRootArg(['--package-root', 'build/app'], '/repo')).toBe('/repo/build/app')
expect(resolveDesktopPackageRootArg(['--', '--package-root', 'build/app'], '/repo')).toBe('/repo/build/app')
const expected = resolve('/repo', 'build/app')
expect(resolveDesktopPackageRootArg(['--package-root', 'build/app'], '/repo')).toBe(expected)
expect(resolveDesktopPackageRootArg(['--', '--package-root', 'build/app'], '/repo')).toBe(expected)
expect(() => resolveDesktopPackageRootArg(['--package-root'])).toThrow('usage: --package-root <path>')
})

Expand Down
Loading