Skip to content

🐛 explicitly set scopes for new mastodon instances#4692

Open
MrKrisKrisu wants to merge 1 commit into
developfrom
dev-ks/2666
Open

🐛 explicitly set scopes for new mastodon instances#4692
MrKrisKrisu wants to merge 1 commit into
developfrom
dev-ks/2666

Conversation

@MrKrisKrisu
Copy link
Copy Markdown
Member

fixes #2666

@HerrLevin
Copy link
Copy Markdown
Member

Code wise this looks good to me.

But have you tested this locally? I mean, did you create an app first and then log in again after making your changes—or try it with a different one?

If not, please try it with multiple instances. Mastodon, Pleroma, GoToSocial, MissKey, etc.
OAuth2 can be tricky to implement. Sometimes changing a scope can break things.

@MrKrisKrisu
Copy link
Copy Markdown
Member Author

If not, please try it with multiple instances. Mastodon, Pleroma, GoToSocial, MissKey

I can test that further. But since when have we supported anything other than Mastodon? We’ve never claimed to support anything else.

@HerrLevin
Copy link
Copy Markdown
Member

But since when have we supported anything other than Mastodon? We’ve never claimed to support anything else.

I know that, but we still have a huge userbase with very specific activitypub configurations (and many without an email address). I'd rather not see them locked out of their account + us having to fix it manually. :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Too many requested scopes

2 participants