Skip to content

fix: Bump CI actions and stabilize flaky notebook checks#1290

Open
huseyincavusbi wants to merge 7 commits intoTransformerLensOrg:devfrom
huseyincavusbi:fix/ci-notebook-nodejs
Open

fix: Bump CI actions and stabilize flaky notebook checks#1290
huseyincavusbi wants to merge 7 commits intoTransformerLensOrg:devfrom
huseyincavusbi:fix/ci-notebook-nodejs

Conversation

@huseyincavusbi
Copy link
Copy Markdown
Contributor

Description

Two changes:

1. Node.js deprecation warnings in CI
Bumped all GitHub Actions to latest stable versions to clear Node.js 20 deprecation warnings (checkout@v3-v4, cache@v3-v4, upload-artifact@v4-v7, download-artifact@v4-v8, setup-uv@v6-v7). Also added workflow_dispatch to checks.yml for manual runs.

2. Flaky notebook checks
Some notebooks (e.g. Santa_Coder) fail intermittently due to tiny floating-point noise across CI runs (~3.9515 vs ~3.9514). Following the same principle as the GQA allclose fix, I added a regex sanitizer to doc_sanitize.cfg that truncates floats to 3 decimal places before comparison. This preserves meaningful numerical checks while absorbing last-bit precision noise.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes
  • I have not rewritten tests relating to key interfaces which would affect backward compatibility

Copilot AI review requested due to automatic review settings May 8, 2026 15:45
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Comment thread demos/doc_sanitize.cfg Outdated
@huseyincavusbi
Copy link
Copy Markdown
Contributor Author

Thanks for pointing this out @jlarson4. I changed it to be scale aware..
What do you think about this now:

  • Numbers ≥ 1 (e.g. 3.9515): truncated to 3 decimals → 3.951
  • Numbers < 1 (e.g. 0.001234): truncated to 4 decimals → 0.0012

@jlarson4
Copy link
Copy Markdown
Collaborator

jlarson4 commented May 8, 2026

@huseyincavusbi Would it be possible have numbers < 1 match to a certain amount of significant figures, say 3 decimals? Examples:

0.001234 to 0.00123
0.01234 to 0.0123

@huseyincavusbi
Copy link
Copy Markdown
Contributor Author

hey @jlarson4 . Updated the regex to use 3 significant figures for small numbers instead of fixed decimals. So 0.001234 now becomes 0.00123 instead of 0.001, keeps the precision where it actually matters

@jlarson4
Copy link
Copy Markdown
Collaborator

jlarson4 commented May 9, 2026

This looks great! I am going to merge, thank you for tackling this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants