fix: Bump CI actions and stabilize flaky notebook checks#1290
Open
huseyincavusbi wants to merge 7 commits intoTransformerLensOrg:devfrom
Open
fix: Bump CI actions and stabilize flaky notebook checks#1290huseyincavusbi wants to merge 7 commits intoTransformerLensOrg:devfrom
huseyincavusbi wants to merge 7 commits intoTransformerLensOrg:devfrom
Conversation
checkout@v3 -> v4 cache@v3 -> v4 cache/restore@v3 -> v4 upload-artifact@v4 -> v7 download-artifact@v4 -> v8 setup-uv@v6 -> v8
jlarson4
reviewed
May 8, 2026
Contributor
Author
|
Thanks for pointing this out @jlarson4. I changed it to be scale aware..
|
Collaborator
|
@huseyincavusbi Would it be possible have numbers < 1 match to a certain amount of significant figures, say 3 decimals? Examples: 0.001234 to 0.00123 |
Contributor
Author
|
hey @jlarson4 . Updated the regex to use 3 significant figures for small numbers instead of fixed decimals. So 0.001234 now becomes 0.00123 instead of 0.001, keeps the precision where it actually matters |
Collaborator
|
This looks great! I am going to merge, thank you for tackling this issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Two changes:
1. Node.js deprecation warnings in CI
Bumped all GitHub Actions to latest stable versions to clear Node.js 20 deprecation warnings (
checkout@v3-v4,cache@v3-v4,upload-artifact@v4-v7,download-artifact@v4-v8,setup-uv@v6-v7). Also addedworkflow_dispatchto checks.yml for manual runs.2. Flaky notebook checks
Some notebooks (e.g. Santa_Coder) fail intermittently due to tiny floating-point noise across CI runs (~3.9515 vs ~3.9514). Following the same principle as the GQA
allclosefix, I added a regex sanitizer todoc_sanitize.cfgthat truncates floats to 3 decimal places before comparison. This preserves meaningful numerical checks while absorbing last-bit precision noise.Type of change
Checklist: