fix(security): Replace eval() with ast.literal_eval() in knowledges.py for safer evaluation#1491
Open
liangzhang-keepmoving wants to merge 1 commit into
Conversation
…y for safer evaluation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Security Fix
This PR addresses the security vulnerability in
superagi/controllers/knowledges.pywhereeval()was being used on marketplace-sourced data.The Problem
The
uninstall_selected_knowledgefunction was usingeval()to parse thevector_idsfield from marketplace-sourced knowledge configurations. This could allow a malicious marketplace knowledge package to execute arbitrary code when uninstalled.The Solution
Replaced
eval()withast.literal_eval()which safely evaluates Python literals without executing arbitrary code.Changes Made
import astat the top of the filevector_ids = eval(knowledge_config["vector_ids"])tovector_ids = ast.literal_eval(knowledge_config["vector_ids"])Testing
The fix maintains the same functionality while providing a safe alternative to
eval()for parsing the vector IDs from the knowledge configuration.This is part of a series of PRs to fix all
eval()usage vulnerabilities in the codebase.