Skip to content

Commit 46c9d87

Browse files
MOB-862 #comment updated ios and JS API signatures
1 parent 8902415 commit 46c9d87

File tree

3 files changed

+31
-17
lines changed

3 files changed

+31
-17
lines changed

ios/TsAuthentication.mm

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,11 +5,11 @@ @interface RCT_EXTERN_MODULE(TsAuthentication, NSObject)
55
RCT_EXTERN_METHOD(initialize:(NSString*)clientId domain:(NSString*)domain baseUrl:(NSString*)baseUrl withResolver:(RCTPromiseResolveBlock)resolve withRejecter:(RCTPromiseRejectBlock)reject)
66

77
//RCT_EXTERN_METHOD(initialize:(NSString *)clientId domain:(NSString*)domain withBaseUrl:(NSString *)baseUrl withResolver:(RCTPromiseResolveBlock)resolve withRejecter:(RCTPromiseRejectBlock)reject)
8-
RCT_EXTERN_METHOD(register:(NSString *)username displayName:(NSString*)displayName withResolver:(RCTPromiseResolveBlock)resolve
8+
RCT_EXTERN_METHOD(registerWebAuthn:(NSString *)username displayName:(NSString*)displayName withResolver:(RCTPromiseResolveBlock)resolve
99
withRejecter:(RCTPromiseRejectBlock)reject)
10-
RCT_EXTERN_METHOD(authenticate:(NSString *)username withResolver:(RCTPromiseResolveBlock)resolve
10+
RCT_EXTERN_METHOD(authenticateWebAuthn:(NSString *)username withResolver:(RCTPromiseResolveBlock)resolve
1111
withRejecter:(RCTPromiseRejectBlock)reject)
12-
RCT_EXTERN_METHOD(signTransaction:(NSString *)username withResolver:(RCTPromiseResolveBlock)resolve
12+
RCT_EXTERN_METHOD(signWebauthnTransaction:(NSString *)username withResolver:(RCTPromiseResolveBlock)resolve
1313
withRejecter:(RCTPromiseRejectBlock)reject)
1414
RCT_EXTERN_METHOD(getDeviceInfo:(RCTPromiseResolveBlock)resolve withRejecter:(RCTPromiseRejectBlock)reject)
1515
RCT_EXTERN_METHOD(isWebAuthnSupported:(RCTPromiseResolveBlock)resolve withRejecter:(RCTPromiseRejectBlock)reject)

ios/TsAuthentication.swift

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,8 @@ class TsAuthentication: NSObject {
2727
}
2828
}
2929

30-
@objc(register:displayName:withResolver:withRejecter:)
31-
func register(
30+
@objc(registerWebAuthn:displayName:withResolver:withRejecter:)
31+
func registerWebAuthn(
3232
_ username: String,
3333
displayName: String,
3434
resolve: @escaping RCTPromiseResolveBlock, reject: @escaping RCTPromiseRejectBlock) -> Void {
@@ -50,8 +50,8 @@ class TsAuthentication: NSObject {
5050
}
5151
}
5252

53-
@objc(authenticate:withResolver:withRejecter:)
54-
func authenticate(
53+
@objc(authenticateWebAuthn:withResolver:withRejecter:)
54+
func authenticateWebAuthn(
5555
_ username: String,
5656
resolve: @escaping RCTPromiseResolveBlock, reject: @escaping RCTPromiseRejectBlock) -> Void {
5757

@@ -69,8 +69,8 @@ class TsAuthentication: NSObject {
6969
}
7070
}
7171

72-
@objc(signTransaction:withResolver:withRejecter:)
73-
func signTransaction(
72+
@objc(signWebauthnTransaction:withResolver:withRejecter:)
73+
func signWebauthnTransaction(
7474
_ username: String,
7575
resolve: @escaping RCTPromiseResolveBlock, reject: @escaping RCTPromiseRejectBlock) -> Void {
7676

src/index.tsx

Lines changed: 22 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,10 @@ export namespace TSAuthenticationSDK {
2828
result: string;
2929
}
3030

31+
export interface DeviceInfo {
32+
33+
}
34+
3135
export const enum TSAuthenticationError {
3236
notInitialized,
3337
userNotFound,
@@ -44,8 +48,11 @@ export namespace TSAuthenticationSDK {
4448

4549
export interface TSAuthenticationSDKModule {
4650
initialize: (clientId: string, domain: string, baseUrl: string) => Promise<boolean>;
47-
register: (username: string, displayName: string) => Promise<TSAuthenticationSDK.TSRegistrationResult>;
48-
authenticate: (username: string) => Promise<TSAuthenticationSDK.TSAuthenticationResult>;
51+
registerWebAuthn: (username: string, displayName: string) => Promise<TSAuthenticationSDK.TSRegistrationResult>;
52+
authenticateWebAuthn: (username: string) => Promise<TSAuthenticationSDK.TSAuthenticationResult>;
53+
signWebauthnTransaction: (username: string) => Promise<TSAuthenticationSDK.TSAuthenticationResult>;
54+
getDeviceInfo: () => Promise<TSAuthenticationSDK.DeviceInfo>;
55+
isWebAuthnSupported: () => Promise<boolean>;
4956
}
5057

5158
class AuthenticationSDK implements TSAuthenticationSDKModule {
@@ -54,17 +61,24 @@ class AuthenticationSDK implements TSAuthenticationSDKModule {
5461
return TsAuthentication.initialize(clientId, domain, baseUrl);
5562
}
5663

57-
register(username: string, displayName: string): Promise<TSAuthenticationSDK.TSRegistrationResult> {
58-
return TsAuthentication.register(username, displayName);
64+
registerWebAuthn(username: string, displayName: string): Promise<TSAuthenticationSDK.TSRegistrationResult> {
65+
return TsAuthentication.registerWebAuthn(username, displayName);
5966
}
6067

61-
authenticate(username: string): Promise<TSAuthenticationSDK.TSAuthenticationResult> {
62-
return TsAuthentication.authenticate(username);
68+
authenticateWebAuthn(username: string): Promise<TSAuthenticationSDK.TSAuthenticationResult> {
69+
return TsAuthentication.authenticateWebAuthn(username);
6370
}
6471

65-
signTransaction(username: string): Promise<TSAuthenticationSDK.TSAuthenticationResult> {
66-
return TsAuthentication.signTransaction(username);
72+
signWebauthnTransaction(username: string): Promise<TSAuthenticationSDK.TSAuthenticationResult> {
73+
return TsAuthentication.signWebauthnTransaction(username);
6774
}
6875

76+
getDeviceInfo(): Promise<TSAuthenticationSDK.DeviceInfo> {
77+
return TsAuthentication.getDeviceInfo();
78+
}
79+
80+
isWebAuthnSupported(): Promise<boolean> {
81+
return TsAuthentication.isWebAuthnSupported();
82+
}
6983
}
7084
export default new AuthenticationSDK();

0 commit comments

Comments
 (0)