-
Notifications
You must be signed in to change notification settings - Fork 50
Adding different types of restrictions between Services especially for DRT #959
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ue71603
wants to merge
37
commits into
v2.0
Choose a base branch
from
extend_service_restrictions_new_modes
base: v2.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 14 commits
Commits
Show all changes
37 commits
Select commit
Hold shift + click to select a range
18b4e82
redoing #958 for next
ue71603 5180f7e
Update netex_serviceRestrictions_version.xsd
ue71603 7677f91
working version with example
ue71603 b364c97
restructured into part 3, examples created and validated
ue71603 90f8baf
fixing a problem
ue71603 eb7a5e6
Lint and update documentation tables
github-actions[bot] fa5e43b
Update xsd/netex_framework/netex_reusableComponents/netex_serviceRest…
ue71603 aec6523
Update xsd/netex_part_3/part3_fares/netex_extendedBookingArrangements…
ue71603 c10d8b1
Update xsd/netex_part_3/part3_fares/netex_extendedBookingArrangements…
ue71603 022dea8
Update xsd/netex_part_3/part3_fares/netex_extendedBookingArrangements…
ue71603 3bea5da
Update xsd/netex_part_3/part3_fares/netex_extendedBookingArrangements…
ue71603 99e44ae
Update xsd/netex_part_3/part3_fares/netex_extendedBookingArrangements…
ue71603 954b5a8
allowing no lines in exclusion and adding more factors
ue71603 8608317
Lint and update documentation tables
github-actions[bot] d0ffcb6
Update xsd/netex_part_3/part3_fares/netex_extendedBookingArrangements…
ue71603 57d5c85
Update xsd/netex_part_3/part3_fares/netex_extendedBookingArrangements…
ue71603 97be1c0
Update xsd/netex_part_3/part3_fares/netex_extendedBookingArrangements…
ue71603 9948dd1
Creade example folder drt and README.md
ue71603 fa51d12
update NeTEx project file
ue71603 ee282b2
start adding examples
ue71603 6ddac1a
Lint and update documentation tables
github-actions[bot] 2aa543b
more raw examples (need to be refined)
ue71603 27ecb7a
Merge branch 'extend_service_restrictions_new_modes' of https://githu…
ue71603 26bc251
Update README.md
ue71603 f1a34ae
fixed some parts
ue71603 7be3898
drt examples 1. cleanup
ue71603 10817c1
Lint and update documentation tables
github-actions[bot] b0b6bd4
better description
ue71603 a80bd90
Merge branch 'extend_service_restrictions_new_modes' of https://githu…
ue71603 b078e28
Lint and update documentation tables
github-actions[bot] 4df3586
new DRT exemple with small zones with quays (#1008)
prhod 50a1fb0
Lint and update documentation tables
github-actions[bot] 9a0e0ab
switching bookingArrangements to ServiceBookingArrangement in Line
ue71603 6cbb0f2
Lint and update documentation tables
github-actions[bot] 05532d8
Update README.md
ue71603 53ce0db
added deep booking links and services first draft
ue71603 7ead8ec
Lint and update documentation tables
github-actions[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ue71603 marked this conversation as resolved.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not think it is a good idea that as a data producer you have to enumerate all regular services ("LINE") to state the competition rules. The data producer will not have these in their system, unless they are a data integration system. Even if they do have all LINEs, the process for determining the competing LINEs is not straight forward. Taxi-like DRT will usually be determined by a geographical area and by operating days and times. So the system would need to determine the stops in the area, then determine the LINEs serving the stops, and then find out if there are any journeys during the operating time of the DRT. I suggest that it is not necessary to state the competing regular LINEs, the journey planner can work that out at run time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@duexw counter-proposal? how would you state them?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is now optional. Also I added some more points.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that is what I had in mind - If you do not state any LINEs, it means that the competitive rule applies to all LINEs.