Skip to content

Commit 00dd753

Browse files
authored
Remove XFAILs for QuadReadAcrossDiagonal tests (llvm#1316)
These are resolved as of llvm/llvm-project#188567
1 parent 878c700 commit 00dd753

6 files changed

Lines changed: 0 additions & 24 deletions

test/WaveOps/QuadReadAcrossDiagonal.32.test

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -336,10 +336,6 @@ DescriptorSets:
336336
...
337337
#--- end
338338

339-
# Unsupported in Clang, I have a working branch for QuadReadAcrossDiagonal intrinsic support
340-
# waiting on https://github.com/llvm/llvm-project/pull/187440 to be merged, so I can open a PR for it
341-
# XFAIL: Clang
342-
343339
# RUN: split-file %s %t
344340
# RUN: %dxc_target -T cs_6_5 -Fo %t.o %t/source.hlsl
345341
# RUN: %offloader %t/pipeline.yaml %t.o

test/WaveOps/QuadReadAcrossDiagonal.convergence.test

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -62,10 +62,6 @@ DescriptorSets:
6262
...
6363
#--- end
6464

65-
# Unsupported in Clang, I have a working branch for QuadReadAcrossDiagonal intrinsic support
66-
# waiting on https://github.com/llvm/llvm-project/pull/187440 to be merged, so I can open a PR for it
67-
# XFAIL: Clang
68-
6965
# RUN: split-file %s %t
7066
# RUN: %dxc_target -T cs_6_0 -Fo %t.o %t/source.hlsl
7167
# RUN: %offloader %t/pipeline.yaml %t.o

test/WaveOps/QuadReadAcrossDiagonal.fp16.test

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -124,10 +124,6 @@ DescriptorSets:
124124

125125
# REQUIRES: Half
126126

127-
# Unsupported in Clang, I have a working branch for QuadReadAcrossDiagonal intrinsic support
128-
# waiting on https://github.com/llvm/llvm-project/pull/187440 to be merged, so I can open a PR for it
129-
# XFAIL: Clang
130-
131127
# RUN: split-file %s %t
132128
# RUN: %dxc_target -enable-16bit-types -T cs_6_5 -Fo %t.o %t/source.hlsl
133129
# RUN: %offloader %t/pipeline.yaml %t.o

test/WaveOps/QuadReadAcrossDiagonal.fp64.test

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -124,10 +124,6 @@ DescriptorSets:
124124

125125
# REQUIRES: Double
126126

127-
# Unsupported in Clang, I have a working branch for QuadReadAcrossDiagonal intrinsic support
128-
# waiting on https://github.com/llvm/llvm-project/pull/187440 to be merged, so I can open a PR for it
129-
# XFAIL: Clang
130-
131127
# RUN: split-file %s %t
132128
# RUN: %dxc_target -T cs_6_5 -Fo %t.o %t/source.hlsl
133129
# RUN: %offloader %t/pipeline.yaml %t.o

test/WaveOps/QuadReadAcrossDiagonal.int16.test

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -232,10 +232,6 @@ DescriptorSets:
232232

233233
# REQUIRES: Int16
234234

235-
# Unsupported in Clang, I have a working branch for QuadReadAcrossDiagonal intrinsic support
236-
# waiting on https://github.com/llvm/llvm-project/pull/187440 to be merged, so I can open a PR for it
237-
# XFAIL: Clang
238-
239235
# RUN: split-file %s %t
240236
# RUN: %dxc_target -enable-16bit-types -T cs_6_5 -Fo %t.o %t/source.hlsl
241237
# RUN: %offloader %t/pipeline.yaml %t.o

test/WaveOps/QuadReadAcrossDiagonal.int64.test

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -232,10 +232,6 @@ DescriptorSets:
232232

233233
# REQUIRES: Int64
234234

235-
# Unsupported in Clang, I have a working branch for QuadReadAcrossDiagonal intrinsic support
236-
# waiting on https://github.com/llvm/llvm-project/pull/187440 to be merged, so I can open a PR for it
237-
# XFAIL: Clang
238-
239235
# Bug: https://github.com/llvm/offload-test-suite/issues/988
240236
# XFAIL: Metal
241237

0 commit comments

Comments
 (0)