Skip to content
This repository was archived by the owner on Feb 1, 2026. It is now read-only.

chore: trying to update deps#145

Merged
alvarosabu merged 4 commits into
mainfrom
chore/update-module-deps
Dec 19, 2024
Merged

chore: trying to update deps#145
alvarosabu merged 4 commits into
mainfrom
chore/update-module-deps

Conversation

@alvarosabu
Copy link
Copy Markdown
Member

No description provided.

@alvarosabu alvarosabu requested a review from userquin December 19, 2024 10:39
@userquin userquin self-assigned this Dec 19, 2024
@userquin
Copy link
Copy Markdown
Member

userquin commented Dec 19, 2024

The problem is the @tresjs/post-processing package, there is no default subpackage export and so resolvePath cannot resolve the real path (nuxt kit will check for the entry point) and will fail when reading the entry point to get the exports.

We can remove @tresjs/post-processing from the packages to read adding @tresjs/post-processing/three and @tresjs/post-processing/pnmdrs when @tresjs/post-processing found, but then we have some name collision:

image

We can change the names for those 3 components and the composable adding some hint to the docs.

@alvarosabu
Copy link
Copy Markdown
Member Author

Hi @userquin unfortunately that's not the only issue, the post processing one belong to #144 , if you downgrade the post processing here there are several issues with the client devtools and the playground with cientos

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented Dec 19, 2024

Open in Stackblitz

npm i https://pkg.pr.new/@tresjs/nuxt@145

commit: d1d78e0

@alvarosabu alvarosabu merged commit f19abcb into main Dec 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants