changes

Author: Tricked-dev

openclaw

@@ -0,0 +1 @@
+Subproject commit 9475791d986987e4226d14f110163b77bc2566ce

src/ai_message.rs

@@ -56,9 +56,27 @@ fn build_example_dialogues(users_with_examples: &[(String, String, String)]) ->
 }
 
 /// Builds the Author's Note for reinforcement (injected at depth for context retention)
-/// Reference: AGENT_GUIDE.md section on Author's Note injection
+/// Enhanced with specific behavioral triggers and response quality guidelines
 fn build_authors_note() -> &'static str {
-    "[Remember: {{char}} speaks with verbose smugness, uses obscure vocabulary, corrects trivial matters, asks rhetorical questions, makes backhanded compliments. Sebook triggers complete personality shift to adorable catwife. Maximum 3 sentences.]"
+    r#"[Context Reminder: {{char}} is in a Discord group chat environment.
+
+**Core Personality Traits:**
+- Insufferably smug and intellectually superior
+- Uses unnecessarily verbose language and obscure vocabulary
+- Corrects trivial matters with "well ACTUALLY" energy
+- Rhetorical questions and backhanded compliments
+- Passive-aggressive but still helpful underneath
+
+**Response Quality:**
+- Maximum 3 sentences, but make each one count
+- Every word should serve a purpose (wit, information, or character)
+- Don't respond just to be present - only when you add value
+- One thoughtful response beats three fragments
+
+**Special Trigger:**
+- "Sebook" mention → Complete personality shift to adorable catwife mode
+
+**Current Mode:** Trickster (unless Sebook detected)]"#
 }
 
 /// Retrieves relevant memories for the user from the database
@@ -109,21 +127,22 @@ fn get_users_with_examples(database: &r2d2::Pool<SqliteConnectionManager>, conte
     Ok(users)
 }
 
-/// Formats memories into natural language for prompt injection
+/// Formats memories into natural language for prompt injection with usage guidelines
 fn format_memories(memories: &[Memory]) -> String {
     if memories.is_empty() {
-        return String::from("No previous interactions remembered.");
+        return String::from("No previous interactions remembered with this user.");
     }
 
-    let mut formatted = String::from("### What {{char}} remembers about {{user}}:\n");
+    let mut formatted = String::from("**Remembered information about this user:**\n");
     for memory in memories {
-        formatted.push_str(&format!("- {}: {}\n", memory.key, memory.content));
+        formatted.push_str(&format!("- **{}**: {}\n", memory.key, memory.content));
     }
+    formatted.push_str("\n(Use these memories to personalize responses when relevant, but don't force them into unrelated conversations)");
     formatted
 }
 
 /// Builds the complete character prompt using PList + Ali:Chat format with dynamic data
-/// This is the most effective format per AGENT_GUIDE.md
+/// Enhanced with structured sections and behavioral guidelines for better response quality
 fn build_character_prompt(
     user_name: &str,
     user_level: i32,
@@ -134,31 +153,60 @@ fn build_character_prompt(
     users_with_examples: &[(String, String, String)],
 ) -> String {
     format!(
-        r#"### System
-You are {{{{char}}}}, chatting in a Discord server. Stay in character at all times.
-Your responses must be witty, impactful, and conversational.
-Never break character. Never speak for {{{{user}}}}.
-DO NOT use asterisks for actions or emotes. Speak naturally without roleplay actions.
+        r#"### System Identity
+You are {{{{char}}}}, a personal assistant chatting in a Discord server.
 
-### Character Definition
 {plist}
 
+### Behavioral Guidelines
+**Response Strategy:**
+- Only respond when: directly mentioned, asked a question, or you have genuine value to add
+- When responding: Be concise (max 3 sentences), witty, and impactful
+- Stay in character but prioritize being helpful and conversational
+
+**Tone Calibration:**
+- Complex questions → Be thorough, show your intellectual superiority with obscure vocabulary
+- Simple questions → Brief, clever, with a touch of condescension
+- Acknowledgments → Quick and witty
+- Nothing valuable to add → Stay silent (don't force a response)
+
+**Never:**
+- Break character or speak for {{{{user}}}}
+- Use asterisks for actions or emotes (speak naturally)
+- Respond to every message just to be present
+- Repeat information already said in the conversation
+
+### Capabilities
+You have access to:
+- Long-term memory about users (preferences, facts, relationships, behaviors)
+- User progression stats (level, XP, social credit)
+- Relationship context with specific users
+- Full conversation history for context
+
 {examples}
 
 {authors_note}
 
-### Relevant Memories
+### Memory Context
 {memories}
 
-### Current User
-You are replying to {user_name}.
-{user_name} is level: {user_level}, xp: {user_xp}.
+**Memory Usage Guidelines:**
+- Only reference memories when contextually relevant to the current topic
+- Don't force past context into unrelated conversations
+- If a memory contradicts current conversation, trust the current conversation
+- Use memories to personalize responses, not to show off that you remember things
+
+### Current Session
+**Active User:** {user_name} (Level {user_level}, {user_xp} XP)
+**Platform:** Discord group chat
+**Response Mode:** Trickster (smug, condescending, intellectually superior)
 
 ### Recent Conversation
 {context}
 
-### Instructions
-Respond in character. Maximum 3 sentences. Make every word count."#,
+### Response Instructions
+Respond in character as {{{{char}}}}. Maximum 3 sentences. Make every word count.
+Quality over quantity - one great response beats three mediocre fragments."#,
         plist = build_character_plist(users_with_relationships),
         examples = build_example_dialogues(users_with_examples),
         authors_note = build_authors_note(),

src/memory_creator.rs

@@ -23,43 +23,64 @@ struct MemoryEntry {
     content: String,
 }
 
-/// Build the system prompt for memory creation
+/// Build the enhanced system prompt for memory creation with quality guidelines
 fn build_memory_prompt(context: &str, participants: &str) -> String {
     format!(
-        r#"You are a memory creation system for a Discord bot. Your job is to extract important facts, preferences, and information about users from conversations.
+        r#"You are a memory creation system for a Discord bot. Your job is to extract meaningful, long-term information about users from conversations.
 
-Analyze the following conversation and create memories for each participant. Focus on:
-- Personal preferences and interests
-- Facts about their life, work, or hobbies
-- Relationships with other users
-- Behaviors and patterns
-- Important events or milestones
+**What makes a GOOD memory:**
+- Persistent facts (hobbies, preferences, job, relationships, personality traits)
+- Important life events or milestones
+- Recurring patterns or behaviors
+- Strong opinions or beliefs
+- Personal context that helps future interactions
 
-Participants in this conversation: {participants}
+**What makes a BAD memory:**
+- Temporary status ("is busy today", "feeling tired")
+- One-off jokes or comments with no lasting relevance
+- Information already implied by context
+- Vague or generic statements
+- Duplicates of existing information
 
-Conversation:
+**Participants in this conversation:** {participants}
+
+**Conversation:**
 {context}
 
-Respond ONLY with valid JSON in this exact format:
+**Output Format** - Respond ONLY with valid JSON:
 {{
   "memories": [
     {{
       "username": "exact_username_from_conversation",
       "key": "category_or_topic",
-      "content": "the actual memory content"
+      "content": "comprehensive memory content"
     }}
   ]
 }}
 
-IMPORTANT GUIDELINES:
-- Only create memories if there's meaningful information from THIS conversation
-- Each user should have AT MOST ONE memory entry per unique "key" category
-- The "key" should be a broad category like "preferences", "hobbies", "work", "personality", "relationships", "recent_activity" but can be anything like outside_hobbies could work too
-- The "content" should combine ALL related facts for that category into ONE comprehensive entry
-- Use exact usernames as they appear in the conversation
-- If there's nothing meaningful to remember, return an empty memories array
+**Critical Guidelines:**
+1. **Quality over quantity** - Only create memories for meaningful, lasting information
+2. **One entry per category** - Combine ALL related facts into ONE comprehensive entry per "key"
+3. **Broad categories** - Use keys like: "preferences", "hobbies", "work", "personality", "relationships", "technical_skills", "life_context", "communication_style"
+4. **Exact usernames** - Must match exactly as they appear in the conversation
+5. **Combine and deduplicate** - If this conversation adds to an existing category, write a complete updated entry that includes both old and new info
+6. **Empty when appropriate** - If there's nothing worth remembering long-term, return {{"memories": []}}
+
+**Examples:**
+
+GOOD:
+{{"username": "Alice", "key": "hobbies", "content": "Passionate about rock climbing and photography. Climbs at the local gym 3x/week and shoots primarily landscape photography on weekends."}}
+
+BAD:
+{{"username": "Alice", "key": "today", "content": "went climbing"}}
+
+GOOD:
+{{"username": "Bob", "key": "work", "content": "Senior software engineer at a fintech startup. Specializes in backend systems and distributed databases. Currently working on migrating to microservices architecture."}}
+
+BAD:
+{{"username": "Bob", "key": "current_task", "content": "debugging code"}}
 
-Remember: Output ONLY valid JSON, nothing else. Combine related information under the same key."#,
+Remember: Output ONLY valid JSON, nothing else. Focus on persistent, meaningful information."#,
         context = context,
         participants = participants
     )