Skip to content
This repository was archived by the owner on Jun 24, 2025. It is now read-only.

Add week note and quarter note support#1579

Merged
eliandoran merged 73 commits intodevelopfrom
calendar
Apr 10, 2025
Merged

Add week note and quarter note support#1579
eliandoran merged 73 commits intodevelopfrom
calendar

Conversation

@JYC333
Copy link
Copy Markdown
Member

@JYC333 JYC333 commented Mar 31, 2025

  • Calendar view now will show week number and dates from prev and next month.
  • Add tag #enableWeekNote and #enableQuarterNote to restruct the journal notes with different levels.

@JYC333 JYC333 marked this pull request as draft March 31, 2025 17:42
@pano9000
Copy link
Copy Markdown
Contributor

quick comment, as I saw lots of date manipulation:

we already use dayjs in frontend and server, and I think you might benefit from leveraging it:
https://day.js.org/en/

Comment thread src/public/translations/en/translation.json
@JYC333
Copy link
Copy Markdown
Member Author

JYC333 commented Mar 31, 2025

quick comment, as I saw lots of date manipulation:

we already use dayjs in frontend and server, and I think you might benefit from leveraging it: https://day.js.org/en/

I see, thanks for mentioning, I'll move to dayjs.

Copy link
Copy Markdown
Contributor

@eliandoran eliandoran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When there is no calendar root, pressing the calendar button crashes it:

image

@eliandoran eliandoran marked this pull request as draft April 6, 2025 13:44
@JYC333 JYC333 marked this pull request as ready for review April 8, 2025 12:05
@JYC333 JYC333 requested a review from eliandoran April 8, 2025 12:06
Copy link
Copy Markdown
Contributor

@eliandoran eliandoran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please solve the compile errors.

@eliandoran eliandoran marked this pull request as draft April 10, 2025 18:36
@github-actions
Copy link
Copy Markdown

Folder/File Previous size New size Difference
/upload/TriliumNextNotes-Server-1579-merge-linux-x64.tar.xz 86.93MB +86.93MB (+100.00%)
TOTAL +86.93MB

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 10, 2025

Folder/File Previous size New size Difference
/upload/TriliumNextNotes-1579-merge-linux-x64.deb 139.46MB +139.46MB (+100.00%)
/upload/TriliumNextNotes-1579-merge-linux-x64.flatpak 132.77MB +132.77MB (+100.00%)
/upload/TriliumNextNotes-1579-merge-linux-x64.rpm 147.42MB +147.42MB (+100.00%)
/upload/TriliumNextNotes-1579-merge-linux-x64.zip 178.39MB +178.39MB (+100.00%)
TOTAL +598.03MB

@JYC333 JYC333 marked this pull request as ready for review April 10, 2025 19:23
@JYC333 JYC333 requested a review from eliandoran April 10, 2025 19:23
@eliandoran eliandoran merged commit a92b040 into develop Apr 10, 2025
10 checks passed
@eliandoran eliandoran deleted the calendar branch April 10, 2025 19:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants