Skip to content
This repository was archived by the owner on Jun 24, 2025. It is now read-only.

fix(build): fix Nx project discovery issue caused by parent .gitignore#2285

Merged
eliandoran merged 2 commits intoTriliumNext:developfrom
werererer:fix/nx-project-discovery
Jun 12, 2025
Merged

fix(build): fix Nx project discovery issue caused by parent .gitignore#2285
eliandoran merged 2 commits intoTriliumNext:developfrom
werererer:fix/nx-project-discovery

Conversation

@werererer
Copy link
Copy Markdown

  • Encountered issue: nx show projects returned empty — no projects detected
  • Root cause: known Nx bug related to parent .gitignore with * (nrwl/nx#27368)
    • In my case: ~/.gitignore contained * because I manage dotfiles with Git — this broke nx show projects and builds
  • Upstream fix is pending
  • Added to .gitignore in project root !* to override parent rules
  • Comment added for context and future reference

@dosubot dosubot Bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jun 11, 2025
@werererer werererer force-pushed the fix/nx-project-discovery branch from 0884403 to c0f36ac Compare June 11, 2025 20:42
@werererer werererer marked this pull request as draft June 11, 2025 20:43
@werererer werererer force-pushed the fix/nx-project-discovery branch from c0f36ac to efb0050 Compare June 11, 2025 20:43
Comment thread .gitignore
*.tsbuildinfo

/result No newline at end of file
/result
Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neovim automatically added a POSIX-compliant end-of-line.
I think we should keep it.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@werererer werererer marked this pull request as ready for review June 11, 2025 20:54
@eliandoran eliandoran added this to the v0.95.0 milestone Jun 11, 2025
@eliandoran eliandoran merged commit 10e063b into TriliumNext:develop Jun 12, 2025
@eliandoran
Copy link
Copy Markdown
Contributor

@werererer , unfortunately this seems to create an extremely bad performance issue with the NX Daemon which consumes a lot of CPU, RAM and also hangs the build from time to time.

I'll have to revert it, if you still have issues with the list of projects not being displayed, perhaps we can find another way.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants