fix(webview): refresh content for SPAs with "query string" in hash

[contributor]

This fixes webview does not refresh its content if you navigate between notes of some SPA sites.

Example: emby media server

It uses pseudo query string located in URL hash, like this: index.html#!/list/list.html?parentId=47835&serverId=abc

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a critical issue preventing webview content from refreshing correctly in Single Page Applications (SPAs) that rely on URL hash-based routing with embedded query strings. By introducing a 'key' prop tied to the 'src' attribute for both 'webview' and 'iframe' components, the system now correctly triggers a re-render of these components whenever the source URL changes, ensuring the displayed content is always up-to-date.

Highlights

• Fixes Webview Refresh Issue: Addresses a problem where webviews did not refresh content when navigating within Single Page Applications (SPAs) that use query strings in URL hashes.
• Forces Component Re-render: Implemented a 'key' prop on 'webview' and 'iframe' elements, set to their 'src' attribute, to ensure these components re-render when the 'src' changes.
• Updates Type Definition: Added the 'key' property to the 'ElectronWebViewElement' interface in the type definitions.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• apps/client/src/types-lib.d.ts
  • Added 'key?: string | number;' to 'ElectronWebViewElement' interface.
• apps/client/src/widgets/type_widgets/WebView.tsx
  • Added 'key={src}' to the 'webview' component in 'DesktopWebView'.
  • Added 'key={src}' to the 'iframe' component in 'BrowserWebView'.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request fixes an issue where webview content for SPAs doesn't refresh on URL hash changes. The solution is to add a key prop to the <webview> and <iframe> elements, using the src as the key. This forces the component to remount when the URL changes, which is a correct and idiomatic approach in Preact. The necessary TypeScript type definition for the <webview> element has also been updated. The changes are effective and well-implemented.