feat(math): Fix mathlive rendering error and add user toggle for mathlive

[Meinzzzz]

Patches a MathLive bug that caused rendering and duplication issues when typing certain LaTeX commands. Also adds a toggle to disable the visual math editor for users who prefer working in raw LaTeX.
#8891

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly improves the math editing experience by addressing a critical bug in the MathLive visual editor and empowering users with greater control over their editing environment. It ensures a more stable and reliable visual editing workflow by fixing issues related to LaTeX command rendering and duplication. Furthermore, it introduces a user-configurable option to toggle the MathLive editor, accommodating diverse user preferences for math input.

Highlights

• MathLive Bug Fix: Resolved a rendering and duplication issue in the MathLive visual editor that occurred when typing specific LaTeX commands.
• User Toggle for MathLive: Introduced a new user setting to enable or disable the visual MathLive editor, providing an option for users who prefer working directly with raw LaTeX.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• apps/client/src/translations/en/translation.json
  • Added new translation keys for the MathLive editor toggle and its descriptive text.
• apps/client/src/widgets/type_widgets/options/text_notes.tsx
  • Integrated an EditorFeature component to display the new MathLive editor toggle in the settings.
• apps/client/src/widgets/type_widgets/text/config.ts
  • Updated the editor configuration to dynamically enable or disable the MathLive field based on the user's mathFieldEnabled option.
• apps/server/src/routes/api/options.ts
  • Included mathFieldEnabled in the list of allowed user options for server-side processing.
• apps/server/src/services/options_init.ts
  • Set the default value for the mathFieldEnabled option to true upon initialization.
• package.json
  • Added a pnpm patched dependency for mathlive@0.108.3 to apply necessary fixes.
• packages/ckeditor5-math/src/augmentation.ts
  • Extended the MathConfig interface to include the new enableMathField property.
• packages/ckeditor5-math/src/mathediting.ts
  • Initialized the enableMathField option to true within the MathEditing plugin's default configuration.
• packages/ckeditor5-math/src/mathui.ts
  • Modified the MainFormView instantiation to pass the enableMathField configuration.
• packages/ckeditor5-math/src/ui/mainformview.ts
  • Updated the constructor to accept and forward the enableMathField parameter to the MathInputView.
• packages/ckeditor5-math/src/ui/mathinputview.ts
  • Introduced a private _enableMathField property to control MathLive behavior.
  • Implemented conditional rendering of the MathLive container based on the _enableMathField setting.
  • Ensured the _loadMathLive function is only invoked when MathLive is enabled.
  • Added a mechanism allowing external listeners to inject custom MathLive shortcuts.
  • Adjusted the focus method to fall back to focusing the LaTeX textarea if MathLive is disabled.
• packages/commons/src/lib/options_interface.ts
  • Defined the mathFieldEnabled property with its description within the OptionDefinitions interface.
• patches/mathlive@0.108.3.patch
  • Applied a patch to mathlive.js and mathlive.mjs to correct the atomIsInRange function logic, resolving rendering issues.
  • Updated package.json references within the patch to use non-minified MathLive files.

Activity

• No specific activity (comments, reviews, or progress updates) has been recorded for this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request successfully implements a feature to toggle the MathLive visual editor, providing users with the choice to work with raw LaTeX directly. The changes are well-integrated, spanning from server-side option handling to the frontend UI and editor configuration. Additionally, a patch is included to fix a bug in MathLive. My review identifies one potential performance issue in the patch file where it's configured to use non-minified library files, which could impact load times.