-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
feat(search): try to improve search performance through some creative mechanisms... #9034
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
35 commits
Select commit
Hold shift + click to select a range
585b6cc
feat(search): try to improve performance
perfectra1n 77733ce
feat(search): try to rice performance some more
perfectra1n 6a06fc7
feat(search): get rid of candidate capping
perfectra1n 9403efa
feat(search): add even some more robust tests
perfectra1n 1c148f4
feat(search): don't toss the entire index after each note change
perfectra1n b533546
fix(search): fix flying bracket
perfectra1n da3d71d
Merge branch 'main' into feat/search-perf-take1
perfectra1n 5718631
fix(search): resolve issue with autocomplete with search performance …
perfectra1n f23a7b4
feat(settings): also allow for fuzzy searching to just be disabled
perfectra1n ba529d2
feat(tests): implement search benchmark test...
perfectra1n ac13af7
feat(search): add FTS5 migration for content search index
perfectra1n dcaebee
feat(search): add FTS5 index service for content search
perfectra1n f358563
feat(search): wire FTS index updates to note content changes
perfectra1n bc09421
feat(search): use FTS5 index in NoteContentFulltextExp with sequentia…
perfectra1n 06fb9c0
test(search): add FTS5 integration test
perfectra1n 24a01ae
feat(search): add user option to enable/disable FTS5 content index
perfectra1n 8fd2cb3
fix(search): fix busy connection error in FTS5 index build
perfectra1n 87fc4e1
docs(search): add FTS5 benchmark results to performance comparison
perfectra1n ac23137
perf(search): optimize scoring, highlighting, and tree walk
perfectra1n 48dd93b
revert: remove FTS5 content search (no measured end-to-end improvement)
perfectra1n 5bc9840
fix(search): restore toLowerCase in fuzzyMatchWordWithResult
perfectra1n 90ac727
docs(search): update benchmark comparison with final optimized numbers
perfectra1n 9aec8be
docs(search): add full search + fuzzy benchmark sections
perfectra1n bd25ae7
docs(search): rewrite benchmark doc for clarity
perfectra1n 5ba7803
Merge branch 'main' into feat/search-perf-take1
eliandoran 9b2be57
docs: remove search analysis
eliandoran 6e90a41
feat(autocomplete): toggle for fuzzy matching (closes #8360)
eliandoran 47ce77e
refactor(search): simplify branching for autocomplete
eliandoran 597c6eb
chore(options): improve descriptions for search
eliandoran ead70ad
fix(autocomplete): fuzzy search not working if the search one was not…
eliandoran 6763f4f
chore(becca): add log for cache memory consumption
eliandoran 885e94c
test(server): migrate database
eliandoran 301f23c
test(server): clean up search scripts
eliandoran e40504b
chore(search): address requested changes
eliandoran f58dd12
chore(search): use loop to prevent nested strip tags injection
eliandoran File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
normalizedName/normalizedValueare computed only inupdate(), but attributes are frequently modified by settingattr.value = ...and then callingattr.save()(e.g.BNote.setAttribute). In that flow, these precomputed fields become stale, causing search/token matching to miss updated attributes. RecomputenormalizedName/normalizedValueinbeforeSaving()(aftersanitizeAttributeName()and value normalization) and/or ensure they are updated whenevername/valuechanges.