A new about dialog

[adoriandoran]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a significant overhaul of the application's 'About' dialog, transforming it into a more informative and aesthetically pleasing interface. The changes aim to provide users with a clearer overview of application details, acknowledge project contributors dynamically, and offer direct access to community resources. This modernization enhances the overall user experience and streamlines the maintenance of project information.

Highlights

• Redesigned About Dialog: The 'About' dialog has been completely revamped with a modern, visually appealing layout, replacing the previous table-based design with structured cards for better readability and user experience.
• Dynamic Contributor List: A new feature dynamically displays a list of project contributors within the 'About' dialog, including their roles and links to their GitHub profiles. This list is automatically generated and updated via a new script.
• Nightly Build Branding: The 'About' dialog now includes specific branding for 'Nightly' builds, featuring an alternative icon and text to clearly distinguish development versions.
• Enhanced Information Display: Version details, build information (including a clickable revision link), and the data directory are presented in a more organized and user-friendly manner. New links for GitHub and donations have also been added.
• Automated Contributor Management: A new script has been introduced to fetch and update the contributors.json file directly from GitHub, ensuring the contributor list in the 'About' dialog remains current without manual intervention.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces a completely redesigned "About" dialog, moving from a simple table to a more modern, card-based layout. It includes new icons, a list of contributors fetched from a JSON file, and links to GitHub and donation pages. A script to automatically update the contributors list from the GitHub API is also added.

The code is well-structured, but I've found a few areas for improvement. Specifically, there's a logic issue in a useCallback hook that causes unnecessary data fetching, a missing key prop in a React list which can cause rendering issues, and an opportunity to improve type safety in the new contributor update script. My detailed comments are below.

[adoriandoran]

/gemini review

[gemini-code-assist]

Code Review

This pull request significantly refactors the 'About' dialog, introducing new SVG icons, updating translation keys, and improving the dialog's styling and layout. It also adds functionality to display contributor information, including a new contributors.json file and a script to generate it. Review comments highlight several issues: a stale closure in useCallback for onLoad that causes inefficient app-info fetching, a logic bug in useEffect related to isNightly state updates and icon class setting, a UI regression where long directory paths in DirectoryLink might overflow due to missing word-break styling, and untyped parameters in the contributorOrderer function in update-contributor-list.ts which should be typed for better code clarity and safety.

[gemini-code-assist]

The parameters a and b in the contributorOrderer function are untyped. In a TypeScript file, it's best practice to provide types for function parameters to improve code clarity and type safety. Based on the context, the type seems to be GithubContributor, which is used in processContributorList.

Suggested change

	function contributorOrderer(a, b) {
	const isAPinned = (a.login in PINNED_CONTRIBUTORS);
	const isBPinned = (b.login in PINNED_CONTRIBUTORS);
	// Pinned contributors come first
	if (isAPinned !== isBPinned) {
	return isAPinned ? -1 : 1;
	}
	// Within each group, sort by contributions
	return b.contributions - a.contributions;
	}
	function contributorOrderer(a: GithubContributor, b: GithubContributor) {
	const isAPinned = (a.login in PINNED_CONTRIBUTORS);
	const isBPinned = (b.login in PINNED_CONTRIBUTORS);
	// Pinned contributors come first
	if (isAPinned !== isBPinned) {
	return isAPinned ? -1 : 1;
	}
	// Within each group, sort by contributions
	return b.contributions - a.contributions;
	}

[adoriandoran]

/gemini review

[gemini-code-assist]

Code Review

This pull request updates the 'About' dialog in the client application, introducing a new contributor list, improved build information display, and updated styling. The changes include adding a script to automatically fetch and update the contributor list from GitHub, defining new shared types for contributors, and refactoring the About dialog component to support these features. I have reviewed the changes and identified that the 'TODO' placeholders in the translation file for contributor roles need to be replaced with actual content before merging.