fix: now when user is protected and session is not active then full s…#9610
Open
ZAKIURREHMAN wants to merge 2 commits into
Open
fix: now when user is protected and session is not active then full s…#9610ZAKIURREHMAN wants to merge 2 commits into
ZAKIURREHMAN wants to merge 2 commits into
Conversation
…creen ui show for enter the password to unprotect
dosubot
Bot
added
the
size:L
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a ProtectedSessionLockScreen component to both desktop and mobile layouts, which serves to lock the application when the root note is protected and no active protected session is available. The ProtectedSession widget was also updated to support an autoFocus property for better user experience. Review feedback suggests improving the robustness of the state updates by ensuring boolean consistency and adding error handling for the asynchronous root note fetch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
now when user is protected and session is not active then full screen ui show for enter the password to unprotect. #9573