Remove duplicate RewardFactionFlags from QuestTemplate

Author: Shauren

WowPacketParser/Parsing/Parsers/QuestHandler.cs

@@ -323,15 +323,17 @@ public static void HandleQuestQueryResponse(Packet packet)
             if (ClientVersion.AddedInVersion(ClientVersionBuild.V3_3_0_10958))
                 quest.RewardArenaPoints = packet.ReadUInt32("RewardArenaPoints");
 
-            // TODO: Find when was this added/removed and what is it
-            if (ClientVersion.AddedInVersion(ClientVersionBuild.V3_3_0_10958) && (ClientVersion.RemovedInVersion(ClientVersionBuild.V4_0_1_13164)))
-                packet.ReadInt32("Unknown Int32");
-
             if (ClientVersion.AddedInVersion(ClientVersionBuild.V4_0_1_13164))
             {
                 quest.RewardSkillLineID = packet.ReadUInt32("RewardSkillLineID");
                 quest.RewardNumSkillUps = packet.ReadUInt32("RewardNumSkillUps");
-                quest.RewardReputationMask = packet.ReadUInt32("RewardReputationMask");
+            }
+
+            if (ClientVersion.AddedInVersion(ClientVersionBuild.V3_3_0_10958))
+                quest.RewardFactionFlags = packet.ReadUInt32("RewardFactionFlags");
+
+            if (ClientVersion.AddedInVersion(ClientVersionBuild.V4_0_1_13164))
+            {
                 quest.QuestGiverPortrait = packet.ReadUInt32("QuestGiverPortrait");
                 quest.QuestTurnInPortrait = packet.ReadUInt32("QuestTurnInPortrait");
             }
@@ -502,7 +504,7 @@ public static void HandleQuestQueryResponse510(Packet packet)
             quest.RequiredPlayerKills = packet.ReadUInt32("RequiredPlayerKills");
             quest.RewardSkillLineID = packet.ReadUInt32("RewardSkillLineID");
             quest.RewardNumSkillUps = packet.ReadUInt32("RewardNumSkillUps");
-            quest.RewardReputationMask = packet.ReadUInt32("RewRepMask");
+            quest.RewardFactionFlags = packet.ReadUInt32("RewardFactionFlags");
             quest.QuestGiverPortrait = packet.ReadUInt32("QuestGiverPortrait");
             quest.QuestTurnInPortrait = packet.ReadUInt32("QuestTurnInPortrait");
 

WowPacketParser/Store/Objects/QuestTemplate.cs

@@ -177,9 +177,6 @@ public sealed record QuestTemplate : IDataModel
         [DBFieldName("RewardNumSkillUps", TargetedDatabaseFlag.SinceWarlordsOfDraenor | TargetedDatabaseFlag.AnyClassic)]
         public uint? RewardNumSkillUps;
 
-        [DBFieldName("RewardReputationMask", TargetedDatabaseFlag.Cataclysm)]
-        public uint? RewardReputationMask;
-
         [DBFieldName("QuestGiverPortrait", TargetedDatabaseFlag.Cataclysm)]
         [DBFieldName("PortraitGiver", TargetedDatabaseFlag.SinceWarlordsOfDraenor | TargetedDatabaseFlag.AnyClassic)]
         public uint? QuestGiverPortrait;
@@ -251,7 +248,8 @@ public sealed record QuestTemplate : IDataModel
         [DBFieldName("RewardFactionOverride", 5)]
         public int?[] RewardFactionOverride;
 
-        [DBFieldName("RewardFactionFlags", TargetedDatabaseFlag.SinceWarlordsOfDraenor | TargetedDatabaseFlag.AnyClassic)]
+        [DBFieldName("RewardReputationMask", TargetedDatabaseFlag.Cataclysm)]
+        [DBFieldName("RewardFactionFlags", TargetedDatabaseFlag.TillWrathOfTheLichKing | TargetedDatabaseFlag.SinceWarlordsOfDraenor | TargetedDatabaseFlag.AnyClassic)]
         public uint? RewardFactionFlags;
 
         [DBFieldName("AreaGroupID", TargetedDatabaseFlag.SinceWarlordsOfDraenor | TargetedDatabaseFlag.AnyClassic)]
@@ -306,9 +304,6 @@ public sealed record QuestTemplate : IDataModel
         [DBFieldName("RequiredItemCount", TargetedDatabaseFlag.TillCataclysm, 6)]
         public uint?[] RequiredItemCount;
 
-        [DBFieldName("Unknown0", TargetedDatabaseFlag.TillWrathOfTheLichKing)]
-        public uint? Unk0;
-
         [DBFieldName("RequiredSpell", TargetedDatabaseFlag.Cataclysm)]
         public uint? RequiredSpell;