Use separate insert-only struct for spell_target_position sql for TARGET_DEST_NEARBY_DB

Closes #945

Author: Shauren

WowPacketParser/SQL/Builders/Spells.cs

@@ -31,28 +31,28 @@ public static string SpellTargetMultiplePositions()
             if (!Settings.SQLOutputFlag.HasAnyFlagBit(SQLOutput.spell_target_position))
                 return string.Empty;
 
-            var rows = new RowList<SpellTargetPosition>();
+            var rows = new RowList<SpellTargetPositionMulti>();
             Dictionary<uint, uint> idCount = new Dictionary<uint, uint>();
 
             foreach (var spellTargetPosition in Storage.SpellTargetMultiplePositions.OrderBy(t => t.Key))
             {
                 foreach (var spellTargetPositionValue in spellTargetPosition.Value)
                 {
                     idCount.TryGetValue(spellTargetPosition.Key, out uint count);
-                    var duplicatedRow = rows.Where(spellTargetPosition2 =>
+                    var duplicatedRow = rows.Any(spellTargetPosition2 =>
                         spellTargetPosition2.Data.ID == spellTargetPosition.Key &&
                         spellTargetPosition2.Data.PositionX == spellTargetPositionValue.Item1.PositionX &&
                         spellTargetPosition2.Data.PositionY == spellTargetPositionValue.Item1.PositionY &&
                         spellTargetPosition2.Data.PositionZ == spellTargetPositionValue.Item1.PositionZ &&
                         spellTargetPosition2.Data.MapID == spellTargetPositionValue.Item1.MapID
-                    ).Any();
+                    );
 
                     if (duplicatedRow)
                         continue;
 
-                    var row = new Row<SpellTargetPosition>
+                    var row = new Row<SpellTargetPositionMulti>
                     {
-                        Data = new SpellTargetPosition
+                        Data = new SpellTargetPositionMulti
                         {
                             ID = spellTargetPosition.Key,
                             EffectIndex = spellTargetPositionValue.Item1.EffectIndex,
@@ -70,7 +70,7 @@ public static string SpellTargetMultiplePositions()
                     rows.Add(row);
                 }
             }
-            return new SQLInsert<SpellTargetPosition>(rows, false).Build();
+            return new SQLInsert<SpellTargetPositionMulti>(rows, false).Build();
         }
     }
 }

WowPacketParser/Store/Objects/SpellTargetPosition.cs

@@ -14,6 +14,36 @@ public sealed record SpellTargetPosition : IDataModel
         public byte? EffectIndex;
 
         [DBFieldName("OrderIndex", TargetedDatabaseFlag.SinceTheWarWithin, true, true)]
+        public int? OrderIndex;
+
+        [DBFieldName("MapID")]
+        public ushort? MapID;
+
+        [DBFieldName("PositionX")]
+        public float? PositionX;
+
+        [DBFieldName("PositionY")]
+        public float? PositionY;
+
+        [DBFieldName("PositionZ")]
+        public float? PositionZ;
+
+        [DBFieldName("VerifiedBuild")]
+        public int? VerifiedBuild = ClientVersion.BuildInt;
+
+        public string EffectHelper;
+    }
+
+    [DBTableName("spell_target_position", TargetedDatabaseFlag.SinceTheWarWithin)]
+    public sealed record SpellTargetPositionMulti : IDataModel
+    {
+        [DBFieldName("ID", true)]
+        public uint? ID;
+
+        [DBFieldName("EffectIndex", true)]
+        public byte? EffectIndex;
+
+        [DBFieldName("OrderIndex", true, true)]
         public string OrderIndex;
 
         [DBFieldName("MapID")]