Conversation
danmcd
left a comment
danmcd
left a comment
There was a problem hiding this comment.
Nits for future me.
| @@ -2,7 +2,7 @@ | |||
| "name": "fw", | |||
| "description": "Administrative tool for managing SmartOS VM firewalls", | |||
| "version": "1.2.2", | |||
There was a problem hiding this comment.
XXX KEBE ASKS, version bump?
There was a problem hiding this comment.
It looks like we don't publish this to NPM or use it elsewhere AFAICT so I don't think it matters much, probably wouldn't hurt to bump patch though while where here.
| @@ -3,8 +3,8 @@ | |||
| "description": "Library for working with Triton/SDC/SmartOS image manifests", | |||
| "version": "3.1.0", | |||
There was a problem hiding this comment.
XXX KEBE ASKS, version bump?
There was a problem hiding this comment.
This has already been updated in the source repo: https://github.com/TritonDataCenter/node-imgmanifest
I'm not sure if we have a special process for updating the modules in this repo since we commit the node_modules directory.
The correct answer for this package.json will be true for every package.json within node_modules, I suspect most, if not all, have been updated in their source repo.
| @@ -2,11 +2,11 @@ | |||
| "name": "sdc-clients", | |||
| "description": "Contains node.js client libraries for SDC REST APIs.", | |||
| "version": "8.2.0", | |||
There was a problem hiding this comment.
XXX KEBE ASKS, version bump?
| * CDDL HEADER END | ||
| * | ||
| * Copyright 2019 Joyent, Inc. | ||
| * Copyright 2022 MNX Cloud, Inc. |
There was a problem hiding this comment.
Will need copyright update.
| "author": { | ||
| "name": "Joyent", | ||
| "url": "joyent.com" | ||
| "name": "Triton Data Center", |
There was a problem hiding this comment.
Worth a version bump?
| "author": { | ||
| "name": "Joyent", | ||
| "url": "joyent.com" | ||
| "name": "Triton Data Center", |
| @@ -4,21 +4,21 @@ | |||
| "description": "Common methods for managing Triton network configuration", | |||
There was a problem hiding this comment.
Version bump worthy?
| @@ -5,7 +5,7 @@ | |||
| "main": "./lib/vasync.js", | |||
| @@ -2,7 +2,7 @@ | |||
| "name": "vmadm", | |||
| "description": "administrative tool(s) for managing VMs", | |||
| "version": "1.0.5", | |||
There was a problem hiding this comment.
This looks like the same situation as the fw module. I don't believe it's used outside of smartos live, a version bump wouldn't hurt but I don't think it's necessary either.
| @@ -1,4 +1,5 @@ | |||
| // Copyright 2015 Joyent, Inc. All rights reserved. | |||
| // Copyright 2022 MNX Cloud, Inc. | |||
|
This has built successfully in the PR-1062 Jenkins job. Beyond that it'll need some testing. |
danmcd
changed the title
|
Successfully built locally with default, debug, and gcc7. Jenkins PR-1062#11 will confirm it on the Jenkins side. |
2 participants
This may be an existing bug, hence the vague branch name and OS-xxxx. This is slipshod right now, and I may either be overreaching OR missing things.