Skip to content

OS-8645 vmadm.8 man page has lines longer than 80 columns#1141

Draft
cneira wants to merge 2 commits into
masterfrom
OS-8645
Draft

OS-8645 vmadm.8 man page has lines longer than 80 columns#1141
cneira wants to merge 2 commits into
masterfrom
OS-8645

Conversation

@cneira
Copy link
Copy Markdown
Contributor

@cneira cneira commented Jun 26, 2025

In this PR, I added Makefile targets to check for lines longer than 80 columns in every manpage that we have in smartos-live.
As a result, I fixed the man pages that failed these checks. I'm not sure about if this the best approach, but as today, this check is already present in fw so I think it won't hurt to make it available to the rest of man pages.
I need to inspect more closely the man pages that I have modified, so I'm marking this PR as draft, but I wanted to open the discussion.

@cneira cneira requested a review from a team June 26, 2025 23:52
Copy link
Copy Markdown
Contributor

@danmcd danmcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copyright nits.

Comment thread man/Makefile
#
# Copyright 2020 Joyent, Inc.
# Copyright 2022 MNX Cloud, Inc.
# Copyright 2025 MNX Cloud, Inc.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bump this up to Edgecast, please?

Comment thread src/Makefile

#
# Copyright 2019 Joyent, Inc.
# Copyright 2025 MNX Cloud, Inc.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants