Conversation
danmcd
reviewed
Jun 27, 2025
| # | ||
| # Copyright 2020 Joyent, Inc. | ||
| # Copyright 2022 MNX Cloud, Inc. | ||
| # Copyright 2025 MNX Cloud, Inc. |
Contributor
There was a problem hiding this comment.
Bump this up to Edgecast, please?
|
|
||
| # | ||
| # Copyright 2019 Joyent, Inc. | ||
| # Copyright 2025 MNX Cloud, Inc. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR, I added Makefile targets to check for lines longer than 80 columns in every manpage that we have in smartos-live.
As a result, I fixed the man pages that failed these checks. I'm not sure about if this the best approach, but as today, this check is already present in fw so I think it won't hurt to make it available to the rest of man pages.
I need to inspect more closely the man pages that I have modified, so I'm marking this PR as draft, but I wanted to open the discussion.