fix: resolve clippy lints across discord-bot crates

- Derive Default for ReactionMode/ReplyToMode with #[default] on variants
- Use char array pattern instead of closure in trim_start_matches
- Collapse else { if let } into else if let
- Suppress too_many_arguments on constructor fns (not worth a builder refactor)

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Author: jramirezhdez02

rsworkspace/crates/discord-bot/src/bridge.rs

@@ -209,6 +209,7 @@ impl TypeMapKey for DiscordBridge<MessagePublisher> {
 
 impl DiscordBridge<MessagePublisher> {
     /// Create a new bridge backed by a real NATS connection.
+    #[allow(clippy::too_many_arguments)]
     pub fn new(
         client: async_nats::Client,
         prefix: String,
@@ -243,6 +244,7 @@ impl DiscordBridge<MessagePublisher> {
 
 impl<P: Publish> DiscordBridge<P> {
     /// Create a new bridge with any publisher (useful for testing with `MockPublisher`).
+    #[allow(clippy::too_many_arguments)]
     pub fn with_publisher(
         publisher: P,
         access_config: AccessConfig,

rsworkspace/crates/discord-bot/src/config.rs

@@ -18,43 +18,33 @@ pub struct Config {
 }
 
 /// Controls which reaction events are forwarded to NATS.
-#[derive(Debug, Clone, Serialize, Deserialize, PartialEq)]
+#[derive(Debug, Clone, Default, Serialize, Deserialize, PartialEq)]
 #[serde(rename_all = "snake_case")]
 pub enum ReactionMode {
     /// Publish no reaction events
     Off,
     /// Only publish reactions to messages sent by the bot itself
+    #[default]
     Own,
     /// Publish all reaction events (default)
     All,
     /// Only publish reactions from users in `reaction_allowlist`
     Allowlist,
 }
 
-impl Default for ReactionMode {
-    fn default() -> Self {
-        ReactionMode::Own
-    }
-}
-
 /// Controls when reply references are added to outbound messages.
-#[derive(Debug, Clone, Serialize, Deserialize, PartialEq)]
+#[derive(Debug, Clone, Default, Serialize, Deserialize, PartialEq)]
 #[serde(rename_all = "snake_case")]
 pub enum ReplyToMode {
     /// Never add a reply reference
     Off,
     /// Add a reply reference only to the first chunk (default)
+    #[default]
     First,
     /// Add a reply reference to every chunk
     All,
 }
 
-impl Default for ReplyToMode {
-    fn default() -> Self {
-        ReplyToMode::First
-    }
-}
-
 /// Discord bot specific configuration
 #[derive(Debug, Clone, Serialize, Deserialize)]
 pub struct DiscordBotConfig {

rsworkspace/crates/discord-bot/src/outbound.rs

@@ -132,7 +132,7 @@ fn chunk_text(text: &str, max_len: usize, max_lines: Option<usize>) -> Vec<Strin
                 bp = boundary; // hard break if no whitespace found
             }
             chunks.push(remaining[..bp].to_string());
-            remaining = remaining[bp..].trim_start_matches(|c: char| c == '\n' || c == ' ');
+            remaining = remaining[bp..].trim_start_matches(['\n', ' ']);
         }
     }
     if chunks.is_empty() {
@@ -424,6 +424,7 @@ impl<N> OutboundProcessor<N>
 where
     N: trogon_nats::SubscribeClient + trogon_nats::PublishClient + Clone + Send + Sync + 'static,
 {
+    #[allow(clippy::too_many_arguments)]
     pub fn new(
         http: Arc<Http>,
         client: N,
@@ -2996,13 +2997,11 @@ where
                             }
                             Err(e) => warn!("Failed to parse emoji '{}': {}", emoji_str, e),
                         }
-                    } else {
-                        if let Err(e) = http.delete_message_reactions(channel, msg).await {
-                            warn!(
-                                "Failed to remove all reactions from {}/{}: {}",
-                                cmd.channel_id, cmd.message_id, e
-                            );
-                        }
+                    } else if let Err(e) = http.delete_message_reactions(channel, msg).await {
+                        warn!(
+                            "Failed to remove all reactions from {}/{}: {}",
+                            cmd.channel_id, cmd.message_id, e
+                        );
                     }
                 }
                 Err(e) => warn!("Failed to deserialize reaction_remove_all command: {}", e),