fix(trogon-nats): harden lease correctness

Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>

Author: yordis

rsworkspace/crates/trogon-cron/src/mocks.rs

@@ -151,7 +151,7 @@ impl Lease for MockLeaderLock {
         }
     }
 
-    async fn release(&self) -> Result<(), MockLockError> {
+    async fn release(&self, _revision: u64) -> Result<(), MockLockError> {
         Ok(())
     }
 }

rsworkspace/crates/trogon-cron/src/scheduler.rs

@@ -5,7 +5,7 @@ use std::time::Duration;
 use async_nats::jetstream;
 use chrono::Utc;
 use futures::{Stream, StreamExt};
-use trogon_nats::lease::{LeaderElection, Lease, NatsKvLease, NatsKvLeaseConfig};
+use trogon_nats::lease::{LeaderElection, Lease, LeaseTiming, NatsKvLease, NatsKvLeaseConfig};
 use uuid::Uuid;
 
 use crate::{
@@ -40,7 +40,12 @@ pub struct Scheduler<C = NatsConfigStore, P = jetstream::Context, L = NatsKvLeas
     tick_publisher: P,
     leader_lock: L,
     node_id: String,
-    leader_renew_interval: Duration,
+    leader_timing: LeaseTiming,
+}
+
+fn default_leader_timing() -> LeaseTiming {
+    LeaseTiming::new(DEFAULT_LEADER_TTL, DEFAULT_LEADER_RENEW_INTERVAL)
+        .expect("default leader lease timing must be valid")
 }
 
 // ── NATS convenience constructor ──────────────────────────────────────────────
@@ -72,7 +77,7 @@ impl Scheduler<NatsConfigStore, jetstream::Context, NatsKvLease> {
             tick_publisher: js,
             leader_lock,
             node_id: Uuid::new_v4().to_string(),
-            leader_renew_interval: leader_config.renew_interval(),
+            leader_timing: leader_config.timing(),
         })
     }
 }
@@ -95,7 +100,7 @@ where
             tick_publisher,
             leader_lock,
             node_id: Uuid::new_v4().to_string(),
-            leader_renew_interval: DEFAULT_LEADER_RENEW_INTERVAL,
+            leader_timing: default_leader_timing(),
         }
     }
 
@@ -120,11 +125,8 @@ where
         let mut jobs = rebuild_jobs_from_snapshot(&HashMap::new(), initial_jobs);
 
         // 3. Leader election.
-        let mut leader = LeaderElection::new(
-            self.leader_lock,
-            self.node_id.clone(),
-            self.leader_renew_interval,
-        );
+        let mut leader =
+            LeaderElection::new(self.leader_lock, self.node_id.clone(), self.leader_timing);
 
         // 4. Main loop.
         let mut tick = tokio::time::interval(TICK_INTERVAL);