Skip to content

Commit 6a45f24

Browse files
authored
chore(rust): replace inline_module_block allows with file-backed modules (#387)
Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
1 parent 5439e8a commit 6a45f24

31 files changed

Lines changed: 389 additions & 499 deletions

File tree

rsworkspace/crates/acp-nats-agent/src/connection.rs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
use acp_nats::jetstream::consumers::commands_observer;
22
use acp_nats::jetstream::streams::commands_stream_name;
3-
use acp_nats::nats::agent::wildcards::GlobalAllSubject;
4-
use acp_nats::nats::session::wildcards::{AllAgentExtSubject, AllAgentSubject};
3+
use acp_nats::nats::subscriptions::{AllAgentExtSubject, AllAgentSubject, GlobalAllSubject};
54
use acp_nats::nats::{GlobalAgentMethod, ParsedAgentSubject, SessionAgentMethod, parse_agent_subject};
65
use acp_nats::{AcpPrefix, AcpSessionId, NatsClientProxy, PromptResponseSubject, ReqId, ResponseSubject};
76
use agent_client_protocol::{

rsworkspace/crates/acp-nats/src/agent/authenticate.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
use super::Bridge;
22
use crate::error::map_nats_error;
3-
use crate::nats::{self, RequestClient, agent};
3+
use crate::nats::{self, RequestClient, global};
44
use agent_client_protocol::{AuthenticateRequest, AuthenticateResponse, Result};
55
use tracing::{info, instrument};
66
use trogon_std::time::GetElapsed;
@@ -21,7 +21,7 @@ pub async fn handle<N: RequestClient, C: GetElapsed, J>(
2121

2222
let result = nats::request_with_timeout::<N, AuthenticateRequest, AuthenticateResponse>(
2323
nats,
24-
&agent::AuthenticateSubject::new(bridge.config.acp_prefix_ref()),
24+
&global::AuthenticateSubject::new(bridge.config.acp_prefix_ref()),
2525
&args,
2626
bridge.config.operation_timeout,
2727
)

rsworkspace/crates/acp-nats/src/agent/bridge.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ use std::cell::RefCell;
33
use crate::config::Config;
44
use crate::nats::{
55
self, ExtSessionReady, FlushClient, FlushPolicy, PublishClient, PublishOptions, RequestClient, RetryPolicy,
6-
SubscribeClient, session,
6+
SubscribeClient, responses,
77
};
88
use crate::pending_prompt_waiters::PendingSessionPromptResponseWaiters;
99
use crate::telemetry::metrics::Metrics;
@@ -111,7 +111,7 @@ async fn publish_session_ready<N: PublishClient + FlushClient>(
111111
return;
112112
}
113113
};
114-
let subject = session::agent::ExtReadySubject::new(prefix, &acp_session_id);
114+
let subject = responses::ExtReadySubject::new(prefix, &acp_session_id);
115115
info!(session_id = %session_id, subject = %subject, "Publishing session.ready");
116116

117117
let message = ExtSessionReady::new(session_id.clone());

rsworkspace/crates/acp-nats/src/agent/cancel.rs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
use super::Bridge;
2-
use crate::nats::{self, FlushClient, PublishClient, session};
2+
use crate::nats::{self, FlushClient, PublishClient, commands, responses};
33
use crate::session_id::AcpSessionId;
44
use agent_client_protocol::{CancelNotification, Error, ErrorCode, Result};
55
use tracing::{info, instrument, warn};
@@ -32,7 +32,7 @@ pub async fn handle<N: PublishClient + FlushClient, C: GetElapsed, J>(
3232
})?;
3333

3434
let prefix = bridge.config.acp_prefix_ref();
35-
let subject = session::agent::CancelSubject::new(prefix, &session_id);
35+
let subject = commands::CancelSubject::new(prefix, &session_id);
3636

3737
let publish_result = nats::publish(
3838
bridge.nats(),
@@ -53,7 +53,7 @@ pub async fn handle<N: PublishClient + FlushClient, C: GetElapsed, J>(
5353
bridge.metrics.record_error("cancel", "cancel_publish_failed");
5454
}
5555

56-
let cancelled_subject = session::agent::CancelledSubject::new(prefix, &session_id);
56+
let cancelled_subject = responses::CancelledSubject::new(prefix, &session_id);
5757
if let Err(e) = bridge
5858
.nats()
5959
.publish_with_headers(cancelled_subject, async_nats::HeaderMap::new(), bytes::Bytes::new())

rsworkspace/crates/acp-nats/src/agent/close_session.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
use super::Bridge;
2-
use crate::nats::{FlushClient, PublishClient, RequestClient, session};
2+
use crate::nats::{FlushClient, PublishClient, RequestClient, commands};
33
use crate::session_id::AcpSessionId;
44
use agent_client_protocol::{CloseSessionRequest, CloseSessionResponse, Error, ErrorCode, Result};
55
use tracing::{info, instrument};
@@ -31,7 +31,7 @@ where
3131
Error::new(ErrorCode::InvalidParams.into(), format!("Invalid session ID: {}", e))
3232
})?;
3333
let prefix = bridge.config.acp_prefix_ref();
34-
let subject = session::agent::CloseSubject::new(prefix, &session_id);
34+
let subject = commands::CloseSubject::new(prefix, &session_id);
3535

3636
let result = bridge
3737
.session_request::<CloseSessionRequest, CloseSessionResponse>(&subject, &args, &session_id)

rsworkspace/crates/acp-nats/src/agent/ext_method.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
use super::Bridge;
22
use crate::error::map_nats_error;
33
use crate::ext_method_name::ExtMethodName;
4-
use crate::nats::{self, RequestClient, agent};
4+
use crate::nats::{self, RequestClient, global};
55
use agent_client_protocol::{Error, ErrorCode, ExtRequest, ExtResponse, Result};
66
use tracing::{info, instrument};
77
use trogon_std::time::GetElapsed;
@@ -28,7 +28,7 @@ pub async fn handle<N: RequestClient, C: GetElapsed, J>(
2828
})?;
2929

3030
let nats = bridge.nats();
31-
let subject = agent::ExtSubject::new(bridge.config.acp_prefix_ref(), &method_name);
31+
let subject = global::ExtSubject::new(bridge.config.acp_prefix_ref(), &method_name);
3232

3333
let result = nats::request_with_timeout::<N, ExtRequest, ExtResponse>(
3434
nats,

rsworkspace/crates/acp-nats/src/agent/ext_notification.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
use super::Bridge;
22
use crate::ext_method_name::ExtMethodName;
3-
use crate::nats::{self, FlushClient, PublishClient, agent};
3+
use crate::nats::{self, FlushClient, PublishClient, global};
44
use agent_client_protocol::{Error, ErrorCode, ExtNotification, Result};
55
use tracing::{info, instrument, warn};
66
use trogon_std::time::GetElapsed;
@@ -31,7 +31,7 @@ pub async fn handle<N: PublishClient + FlushClient, C: GetElapsed, J>(
3131
Error::new(ErrorCode::InvalidParams.into(), format!("Invalid method name: {}", e))
3232
})?;
3333

34-
let subject = agent::ExtNotifySubject::new(bridge.config.acp_prefix_ref(), &method_name);
34+
let subject = global::ExtNotifySubject::new(bridge.config.acp_prefix_ref(), &method_name);
3535

3636
let publish_result = nats::publish(
3737
bridge.nats(),

rsworkspace/crates/acp-nats/src/agent/fork_session.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
use super::Bridge;
2-
use crate::nats::{FlushClient, PublishClient, RequestClient, session};
2+
use crate::nats::{FlushClient, PublishClient, RequestClient, commands};
33
use crate::session_id::AcpSessionId;
44
use agent_client_protocol::{Error, ErrorCode, ForkSessionRequest, ForkSessionResponse, Result};
55
use tracing::{Span, info, instrument};
@@ -31,7 +31,7 @@ where
3131
Error::new(ErrorCode::InvalidParams.into(), format!("Invalid session ID: {}", e))
3232
})?;
3333
let prefix = bridge.config.acp_prefix_ref();
34-
let subject = session::agent::ForkSubject::new(prefix, &session_id);
34+
let subject = commands::ForkSubject::new(prefix, &session_id);
3535

3636
let result = bridge
3737
.session_request::<ForkSessionRequest, ForkSessionResponse>(&subject, &args, &session_id)

rsworkspace/crates/acp-nats/src/agent/initialize.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
use super::Bridge;
22
use crate::error::map_nats_error;
3-
use crate::nats::{self, RequestClient, agent};
3+
use crate::nats::{self, RequestClient, global};
44
use agent_client_protocol::{InitializeRequest, InitializeResponse, Result};
55
use tracing::{info, instrument};
66
use trogon_std::time::GetElapsed;
@@ -21,7 +21,7 @@ pub async fn handle<N: RequestClient, C: GetElapsed, J>(
2121
info!(client = %client_name, "Initialize request");
2222

2323
let nats = bridge.nats();
24-
let subject = agent::InitializeSubject::new(bridge.config.acp_prefix_ref());
24+
let subject = global::InitializeSubject::new(bridge.config.acp_prefix_ref());
2525

2626
let result = nats::request_with_timeout::<N, InitializeRequest, InitializeResponse>(
2727
nats,

rsworkspace/crates/acp-nats/src/agent/list_sessions.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
use super::Bridge;
22
use crate::error::map_nats_error;
3-
use crate::nats::{self, RequestClient, agent};
3+
use crate::nats::{self, RequestClient, global};
44
use agent_client_protocol::{ListSessionsRequest, ListSessionsResponse, Result};
55
use tracing::{info, instrument};
66
use trogon_std::time::GetElapsed;
@@ -15,7 +15,7 @@ pub async fn handle<N: RequestClient, C: GetElapsed, J>(
1515
info!("List sessions request");
1616

1717
let nats = bridge.nats();
18-
let subject = agent::SessionListSubject::new(bridge.config.acp_prefix_ref());
18+
let subject = global::SessionListSubject::new(bridge.config.acp_prefix_ref());
1919

2020
let result = nats::request_with_timeout::<N, ListSessionsRequest, ListSessionsResponse>(
2121
nats,

0 commit comments

Comments
 (0)