feat(trogon-cron): harden job modeling and scheduling

Author: yordis

rsworkspace/crates/trogon-cron/Cargo.toml

@@ -2,6 +2,7 @@
 name = "trogon-cron"
 version = "0.1.0"
 edition = "2024"
+autotests = false
 
 [features]
 test-support = []
@@ -35,3 +36,12 @@ uuid = { version = "1", features = ["v4"] }
 [[bin]]
 name = "trogon-cron"
 path = "src/main.rs"
+
+[[test]]
+name = "cron_unit"
+path = "tests/cron_unit.rs"
+required-features = ["test-support"]
+
+[[test]]
+name = "integration"
+path = "tests/integration.rs"

rsworkspace/crates/trogon-cron/src/client.rs

@@ -1,7 +1,8 @@
 use async_nats::jetstream;
 
 use crate::{
-    config::JobConfig, error::CronError, nats_impls::NatsConfigStore, traits::ConfigStore,
+    config::JobConfig, domain::RegisteredJob, error::CronError, nats_impls::NatsConfigStore,
+    traits::ConfigStore,
 };
 
 /// Client for registering and managing CRON job configs.
@@ -50,44 +51,12 @@ impl<C: ConfigStore> CronClient<C> {
 
     /// Register or update a job. Existing jobs with the same `id` are overwritten.
     ///
-    /// Structural constraints on `Action::Spawn` configs are validated here so
-    /// callers get an immediate error rather than a silent scheduler-side skip.
-    /// Filesystem checks (file exists, is executable) are intentionally omitted
-    /// because the client may run on a different host than the scheduler.
+    /// Structural config constraints are validated here so callers get an
+    /// immediate error rather than a silent scheduler-side skip. Filesystem
+    /// checks for spawned binaries are intentionally omitted because the client
+    /// may run on a different host than the scheduler.
     pub async fn register_job(&self, config: &JobConfig) -> Result<(), CronError> {
-        if let crate::config::Action::Publish { subject } = &config.action {
-            if !subject.starts_with("cron.") {
-                return Err(CronError::InvalidJobConfig {
-                    reason: format!("publish subject must start with 'cron.', got: {subject}"),
-                });
-            }
-        }
-        if let crate::config::Action::Spawn {
-            bin,
-            args,
-            timeout_sec,
-            ..
-        } = &config.action
-        {
-            if !std::path::Path::new(bin).is_absolute() {
-                return Err(CronError::InvalidJobConfig {
-                    reason: format!("bin must be an absolute path, got: {bin}"),
-                });
-            }
-            for arg in args {
-                if arg.contains('\0') {
-                    return Err(CronError::InvalidJobConfig {
-                        reason: format!("argument contains null byte: {arg:?}"),
-                    });
-                }
-            }
-            if timeout_sec.is_some_and(|s| s == 0) {
-                return Err(CronError::InvalidJobConfig {
-                    reason: "timeout_sec must be >= 1 when set".into(),
-                });
-            }
-        }
-
+        let _ = RegisteredJob::try_from(config)?;
         self.store.put_job(config).await?;
         tracing::info!(job_id = %config.id, "Job registered");
         Ok(())

rsworkspace/crates/trogon-cron/src/config.rs

@@ -47,8 +47,9 @@ pub struct RetryConfig {
     /// Must be >= 1.
     #[serde(default = "default_retry_backoff_sec")]
     pub retry_backoff_sec: u64,
-    /// Hard ceiling on the per-attempt delay in seconds.  Overrides the implicit 32×
-    /// cap when set to a lower value.  Must be >= `retry_backoff_sec` and >= 1.
+    /// Hard ceiling on the per-attempt delay in seconds. Overrides the implicit 32x
+    /// cap when set. It may be lower than `retry_backoff_sec`, which clamps every
+    /// retry delay to `max_backoff_sec`. Must be >= 1 when set.
     #[serde(default, skip_serializing_if = "Option::is_none")]
     pub max_backoff_sec: Option<u64>,
     /// Total time budget in seconds for all retry attempts combined.