refactor: centralize constants into per-crate constants.rs files (#63)

Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>

Author: yordis

rsworkspace/Cargo.lock

@@ -61,7 +61,7 @@ impl std::fmt::Display for DispatchError {
     }
 }
 
-const DEFAULT_OPERATION_TIMEOUT: Duration = Duration::from_secs(30);
+use crate::constants::DEFAULT_OPERATION_TIMEOUT;
 
 pub struct AgentSideNatsConnection<N> {
     nats: N,

rsworkspace/crates/acp-nats-agent/src/connection.rs

@@ -0,0 +1,3 @@
+use std::time::Duration;
+
+pub const DEFAULT_OPERATION_TIMEOUT: Duration = Duration::from_secs(30);

rsworkspace/crates/acp-nats-agent/src/constants.rs

@@ -1,3 +1,4 @@
 mod connection;
+pub mod constants;
 
 pub use connection::{AgentSideNatsConnection, ConnectionError};

rsworkspace/crates/acp-nats-agent/src/lib.rs

@@ -1,10 +1,9 @@
 use acp_nats::{AcpPrefix, AcpPrefixError, Config, NatsConfig};
 use clap::Parser;
-use std::net::{IpAddr, Ipv4Addr};
+use std::net::IpAddr;
 use trogon_std::env::ReadEnv;
 
-const DEFAULT_HOST: IpAddr = IpAddr::V4(Ipv4Addr::new(127, 0, 0, 1));
-const DEFAULT_PORT: u16 = 8080;
+use crate::constants::{DEFAULT_HOST, DEFAULT_PORT};
 
 #[derive(Parser, Debug)]
 #[command(name = "acp-nats-ws")]
@@ -50,6 +49,7 @@ pub fn apply_timeout_overrides<E: ReadEnv>(mut ws: WsConfig, env_provider: &E) -
 #[cfg(test)]
 mod tests {
     use super::*;
+    use std::net::Ipv4Addr;
     use trogon_std::env::InMemoryEnv;
 
     fn config_from_env(env: &InMemoryEnv) -> WsConfig {

rsworkspace/crates/acp-nats-ws/src/config.rs

@@ -9,7 +9,7 @@ use tokio::sync::watch;
 use tracing::{error, info, warn};
 use trogon_std::time::SystemClock;
 
-const DUPLEX_BUFFER_SIZE: usize = 64 * 1024;
+use crate::constants::DUPLEX_BUFFER_SIZE;
 
 /// Handles a single WebSocket connection by bridging it to NATS via ACP.
 pub async fn handle<N>(

rsworkspace/crates/acp-nats-ws/src/connection.rs

@@ -0,0 +1,6 @@
+use std::net::{IpAddr, Ipv4Addr};
+
+pub const DEFAULT_HOST: IpAddr = IpAddr::V4(Ipv4Addr::new(127, 0, 0, 1));
+pub const DEFAULT_PORT: u16 = 8080;
+pub const DUPLEX_BUFFER_SIZE: usize = 64 * 1024;
+pub const THREAD_NAME: &str = "acp-ws-local";

rsworkspace/crates/acp-nats-ws/src/constants.rs

@@ -1,5 +1,6 @@
 mod config;
 mod connection;
+mod constants;
 mod upgrade;
 
 use tokio::sync::{mpsc, watch};
@@ -82,7 +83,7 @@ async fn main() -> Result<(), Box<dyn std::error::Error>> {
 #[cfg(coverage)]
 fn main() {}
 
-const THREAD_NAME: &str = "acp-ws-local";
+use constants::THREAD_NAME;
 
 /// Runs a single-threaded tokio runtime with a
 /// `LocalSet`. All WebSocket connections are processed here because the ACP

rsworkspace/crates/acp-nats-ws/src/main.rs

@@ -9,11 +9,10 @@
 
 use std::sync::Arc;
 
+use crate::constants::MAX_PREFIX_LENGTH;
 use crate::nats::token;
 use crate::subject_token_violation::SubjectTokenViolation;
 
-const MAX_PREFIX_LENGTH: usize = 128;
-
 /// Error returned when [`AcpPrefix`] validation fails.
 #[derive(Debug, Clone, PartialEq)]
 pub struct AcpPrefixError(pub SubjectTokenViolation);

rsworkspace/crates/acp-nats/src/acp_prefix.rs

@@ -1,5 +1,4 @@
 use std::cell::RefCell;
-use std::time::Duration;
 
 use crate::config::Config;
 use crate::nats::{
@@ -30,13 +29,7 @@ use super::{
     set_session_mode, set_session_model,
 };
 
-/// Delay before publishing `session.ready` to NATS.
-///
-/// The `Agent` trait returns the response value *before* the transport layer
-/// serializes and writes it to the client. Without a delay the spawned task
-/// could publish `session.ready` before the client has received the
-/// `session/new` response, violating the ordering guarantee.
-const SESSION_READY_DELAY: Duration = Duration::from_millis(100);
+use crate::constants::SESSION_READY_DELAY;
 
 pub struct Bridge<N, C: GetElapsed> {
     pub(crate) nats: N,