Commit 2540859
fix: resolve NameError in settings Appearance tab by defining select_widget (#51)
* fix: resolve NameError in settings Appearance tab by defining select_widget
The method created a Select widget inline inside
but then referenced an undefined variable
to call and add a duplicate field, causing a NameError
crash whenever the Appearance category was selected.
Fix: store the Select widget in a local variable before passing it to
, and remove the duplicate field addition.
Closes #42
* test: fix help docs test by adding _import_module to fake kernel
The test_run_help_prints_docstring_for_known_command test was failing
because the fake kernel lacked a _import_module method, causing the
module import to fail silently and fall through to the error message.
Add a working _fake_import_module that uses importlib to resolve
the module path, allowing run_help to read and print the docstring.
* fix: resolve NameError crash at startup by defining argv before use
The function referenced a bare name that was
never imported or defined, causing a NameError crash on every invocation.
Fix: move before the conditional block so it is
always defined when reached by the comparison at the end of the function.
Closes #40
* fix: remove dead _fake_import_module from test
---------
Co-authored-by: Ziang Zhang <zhangziang@ncti-gba.cn>
Co-authored-by: Akshaj Singhal <85437940+AkshajSinghal@users.noreply.github.com>1 parent 8d16375 commit 2540859
2 files changed
Lines changed: 4 additions & 11 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
29 | 29 | | |
30 | 30 | | |
31 | 31 | | |
32 | | - | |
33 | | - | |
34 | | - | |
35 | 32 | | |
36 | 33 | | |
37 | 34 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
167 | 167 | | |
168 | 168 | | |
169 | 169 | | |
170 | | - | |
171 | | - | |
172 | | - | |
173 | | - | |
174 | | - | |
175 | | - | |
176 | | - | |
| 170 | + | |
| 171 | + | |
| 172 | + | |
| 173 | + | |
177 | 174 | | |
178 | | - | |
179 | 175 | | |
180 | 176 | | |
181 | 177 | | |
| |||
0 commit comments