[ACL-253] Add scheme_id field to Payout and Refund transactions#366
Merged
Conversation
This commit adds support for the scheme_id field in merchant account /transactions endpoint responses for Payouts and Refunds. The scheme_id field provides information about the payment scheme used for executing payouts and refunds. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Add missing ACL-290 entry for version 17.3.0 (sub_merchants support) - Update ACL-253 entry to version 17.4.0 (scheme_id support) - Update gradle.properties version to 17.4.0 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
Adds support for the scheme_id field on payout and refund transactions by updating fixtures, entities, tests, and versioning.
- Extend
PayoutandRefundclasses with a newschemeIdfield and getter - Update JSON test fixtures and constructor calls in
TransactionTests - Bump version to 17.4.0 and document the change in
CHANGELOG.md
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/test/resources/__files/merchant_accounts/200.get_transactions.json | Add "scheme_id" entries alongside existing transaction IDs |
| src/test/java/com/truelayer/java/merchantaccounts/entities/transactions/TransactionTests.java | Insert null for the new schemeId parameter in test constructors |
| src/main/java/com/truelayer/java/merchantaccounts/entities/transactions/Refund.java | Import SchemeId, add schemeId field and getSchemeId getter |
| src/main/java/com/truelayer/java/merchantaccounts/entities/transactions/Payout.java | Import SchemeId, add schemeId field and getSchemeId getter |
| gradle.properties | Bump project version from 17.3.0 to 17.4.0 |
| CHANGELOG.md | Document new scheme_id support in version 17.4.0 |
Comments suppressed due to low confidence (1)
src/main/java/com/truelayer/java/merchantaccounts/entities/transactions/Payout.java:66
- Consider adding a unit test to verify that
schemeIdis correctly serialized/deserialized and accessible viagetSchemeId().
public Optional<SchemeId> getSchemeId() {
dili91
approved these changes
Aug 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.