Conversation
dili91
commented
Oct 23, 2025
Contributor
Author
There was a problem hiding this comment.
There's a bug on the GET /payouts/$id endpoint whereby a timestamp instead of a date is returned.
That is going to be fixed in future, in the meantime I've added this custom deserializer to let library users just deal with dates.
dili91
commented
Oct 23, 2025
dili91
commented
Oct 23, 2025
Contributor
Author
There was a problem hiding this comment.
I'm not considering this a breaking change, because:
- library users are not expected to instantiate CreatePayoutResponse objects their own
- the getter for the id field is left untouched
dili91
commented
Oct 23, 2025
Comment on lines
+153
to
+159
| URI hp2Uri = tlClient.hppLinkBuilder() | ||
| .resourceType(ResourceType.PAYOUT) | ||
| .resourceId(payoutId) | ||
| .resourceToken(resourceToken) | ||
| .returnUri(URI.create(RETURN_URI)) | ||
| .build(); | ||
| assertCanBrowseLink(hp2Uri); |
Contributor
Author
There was a problem hiding this comment.
At the minute, we don't have a way to trigger execution in an headless fashion in sandbox, hence this test is doing less that what we do elsewhere on acceptance tests
tl-luca-baggi
approved these changes
Oct 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for Verified payouts.