Skip to content

Commit 5db4076

Browse files
committed
fix: relax release napi artifact validation
1 parent 823f750 commit 5db4076

File tree

1 file changed

+4
-15
lines changed

1 file changed

+4
-15
lines changed

.github/workflows/release-cli.yml

Lines changed: 4 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -252,20 +252,10 @@ jobs:
252252
shell: bash
253253
run: |
254254
shopt -s nullglob
255-
get_min_size_for_binding() {
256-
local node_file="$1"
257-
case "$(basename "$node_file")" in
258-
napi-logger.*.node|napi-script-runtime.*.node)
259-
echo $((512 * 1024))
260-
;;
261-
napi-md-compiler.*.node|napi-memory-sync-cli.*.node)
262-
echo $((1024 * 1024))
263-
;;
264-
*)
265-
echo $((256 * 1024))
266-
;;
267-
esac
268-
}
255+
# Keep a small floor to catch obviously broken artifacts, but avoid
256+
# binding-specific thresholds that can flap on harmless linker output
257+
# changes across toolchains.
258+
min_size=$((128 * 1024))
269259
for target_dir in cli/npm/*/; do
270260
if [ ! -f "${target_dir}package.json" ]; then
271261
continue
@@ -274,7 +264,6 @@ jobs:
274264
if [ ! -f "$node_file" ]; then
275265
continue
276266
fi
277-
min_size=$(get_min_size_for_binding "$node_file")
278267
size=$(stat -c%s "$node_file" 2>/dev/null || stat -f%z "$node_file" 2>/dev/null || echo 0)
279268
if [ "$size" -lt "$min_size" ]; then
280269
echo "ERROR: ${node_file} is too small (${size} bytes), expected at least ${min_size} bytes"

0 commit comments

Comments
 (0)