refactor: handle potential None case when retrieving milestone updates in validate_milestone_status_change_conditions

armandocodecr · armandocodecr · commit a308b36b2ed4 · 2026-02-25T16:54:55.000-06:00
diff --git a/contracts/escrow/src/core/validators/milestone.rs b/contracts/escrow/src/core/validators/milestone.rs
@@ -20,7 +20,9 @@ pub fn validate_milestone_status_change_conditions(
     }
 
     for i in 0..milestone_updates.len() {
-        let update = milestone_updates.get(i).unwrap();
+        let update = milestone_updates
+            .get(i)
+            .ok_or(ContractError::MilestoneToUpdateDoesNotExist)?;
 
         if update.status.is_empty() {
             return Err(ContractError::EmptyMilestoneStatus);

Original file line number	Diff line number	Diff line change
`@@ -20,7 +20,9 @@ pub fn validate_milestone_status_change_conditions(`
`20`	`20`	`}`
`21`	`21`
`22`	`22`	`for i in 0..milestone_updates.len() {`
`23`		`- let update = milestone_updates.get(i).unwrap();`
	`23`	`+ let update = milestone_updates`
	`24`	`+ .get(i)`
	`25`	`+ .ok_or(ContractError::MilestoneToUpdateDoesNotExist)?;`
`24`	`26`
`25`	`27`	`if update.status.is_empty() {`
`26`	`28`	`return Err(ContractError::EmptyMilestoneStatus);`