[gothic 2][bug] learning does not increase abilities

[dominikwelke]

Describe the bug
I started playing Gothic 2 base on ubuntu 22.04LTS using OG version gothic-linux-v1.0.3010
thanks for the work and the cool project!

my bug:
When i invest LP into fighting skills (tried one-handed and bow so far) the character abilities do not actually increase but stay on 0%.
LP are deducted as normal.
Other skills can be learned alright (taking animal parts etc).

Save-game/Log-file/Screenshots/Video
save_slot_3.zip

Application log
If relevant attach log.txt file or, in case of game-crash, crash.log

[Try]

Hi, @dominikwelke and thanks for report!

Unfortunately, can't load your save neither with G2Notr, nither with classic. What installation and language are you using as a base? Steam/GoG? EN/DE/RU?

[dominikwelke]

hi @Try

i run Gothic 2 Gold edition, German, installed from CD

[Try]

Reproduced with Gothic2-gold from GoG - looking into

[Try]

Reproduced with Gothic2-gold from GoG - looking into

My bad - misunderstood translation in dialog :P
With GoG version one-handled seem to work, and can't load the save - it's not compatible with GoG or Steam.

[thokkat]

It's the "real" G2 classic, no surprise nothing modern works.

Problem was C_NPC.effect doesn't exist in classic preventing some members like HITCHANCE from being registered.

    // Gothic 2 only
    if (s.find_symbol_by_name("C_NPC.EFFECT") != nullptr) {
        s.register_member("C_NPC.EFFECT", &INpc::effect);
        s.register_member("C_NPC.HITCHANCE", &INpc::hitchance);
        s.register_member("C_NPC.BODYSTATEINTERRUPTABLEOVERRIDE", &INpc::bodystate_interruptable_override);
        s.register_member("C_NPC.NOFOCUS", &INpc::no_focus);
    }

Fix proposal: GothicKit/ZenKit#116.

[thokkat]

Tested with updated Zenkit locally, works now as expected.

[dominikwelke]

i would be happy to test/confirm, too, but I struggle to build OG from source with the updated Zenkit.
(glslangValidator is missing; maybe an obvious issue but i'm new to setting up build environments..)

@Try - would you mind trigger a CI build, so i can download the asset?

[Try]

@dominikwelke

I've updated ZenKit - CI build should be ready in about 2 hours.

glslangValidator

This is shader compiler, that is part of vulkan. On Windows/Linux, you should get it automatically, after installing vulkan-sdk.
On macos - brew install glslang