Skip to content

Commit 658bc11

Browse files
committed
Moved the runtime and typings onto Node 24 alongside .nvmrc
The Renovate update only bumped .nvmrc, which nothing in CI or production reads: the Cloud Run image and every test container come from the Dockerfile FROM line, and our docker:disableMajor preset means Renovate can never bump that base image major itself. Merged alone, the repo would declare Node 24 while everything that actually runs stayed on 22 — and a green build here would prove nothing, since the tests execute inside the Node 22 image. - Dockerfile base image → node:24.18.0-alpine, so tests and production genuinely move to 24 - @types/node → 24.13.3 and the renovate allowedVersions pin '<23' → '<25', per the lockstep rule documented in renovate.json5
1 parent 5d82a87 commit 658bc11

4 files changed

Lines changed: 168 additions & 163 deletions

File tree

.github/renovate.json5

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -36,16 +36,16 @@
3636
]
3737
},
3838

39-
// Pin @types/node to the deployed Node runtime major (22.x, see Dockerfile
39+
// Pin @types/node to the deployed Node runtime major (24.x, see Dockerfile
4040
// and .nvmrc). Bumping the typings ahead of the runtime lets the compiler
41-
// accept Node-24-only APIs that won't exist in production. Bump
42-
// allowedVersions in lockstep when the Node base image is upgraded.
41+
// accept APIs that won't exist in production. Bump allowedVersions in
42+
// lockstep when the Node base image is upgraded.
4343
{
4444
description: 'Pin @types/node to the deployed Node runtime major',
4545
matchPackageNames: [
4646
'@types/node',
4747
],
48-
allowedVersions: '<23',
48+
allowedVersions: '<25',
4949
},
5050
],
5151
}

Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
FROM node:22.23.1-alpine@sha256:16e22a550f3863206a3f701448c45f7912c6896a62de43add43bb9c86130c3e2
1+
FROM node:24.18.0-alpine@sha256:a0b9bf06e4e6193cf7a0f58816cc935ff8c2a908f81e6f1a95432d679c54fbfd
22

33
RUN apk add python3 g++ make
44
RUN apk add --no-cache ca-certificates

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@
5050
"@fedify/cli": "2.3.2",
5151
"@types/html-to-text": "9.0.4",
5252
"@types/jsonwebtoken": "9.0.10",
53-
"@types/node": "22.20.1",
53+
"@types/node": "24.13.3",
5454
"@types/node-jose": "1.1.13",
5555
"@types/sanitize-html": "2.16.1",
5656
"@types/sinon": "22.0.0",

0 commit comments

Comments
 (0)