Fixed expired key cleanup deleting concurrently refreshed values

The expired-entry cleanup in get() deleted by key alone, so between
reading an expired row and issuing the delete, a set() on another
instance could refresh the same key - and the delete would then remove
the brand-new value, making a successful write silently vanish until
the next set(). Scoping the delete to rows that are still expired
closes the race; the periodic cleanup in set() already guards its
delete the same way.

Author: sagzy

src/knex.kvstore.ts

@@ -58,7 +58,12 @@ export class KnexKvStore implements KvStore {
                 `KnexKvStore: Deleting expired key ${key}`,
                 keyInfo,
             );
-            await this.knex(this.table).where(query).del();
+            // Only delete if still expired - a concurrent set() may have
+            // refreshed the row between our read and this delete
+            await this.knex(this.table)
+                .where(query)
+                .where('expires', '<=', new Date())
+                .del();
             return undefined;
         }
         if (row.value === null) {