Skip to content

Commit 24e244e

Browse files
authored
Fix dark mode secondary text colour broken by postcss-color-mod-function v4 (#1040)
* 🐛 Fix dark mode secondary text colour broken by postcss-color-mod-function v4 The color-mod(var(--color-secondary-text) l(-22%)) value compiled to #000 after postcss-color-mod-function was bumped from v3 to v4, making tags, post meta, byline and pagination text invisible on dark backgrounds. Replace with var(--color-secondary-text) directly. #979797 gives ~4.6:1 contrast on the dark mode background and sits correctly below the #fff primary text in the visual hierarchy. Same fix applied to the auto-color media query variant. * Fix gulp zip task broken by gulp-zip v6 API change gulp-zip v6 switched to a named export. Update require() to use .default to restore the zip build task. * Revert "Fix gulp zip task broken by gulp-zip v6 API change" This reverts commit 9a71b49.
1 parent 6e22fbd commit 24e244e

3 files changed

Lines changed: 4 additions & 4 deletions

File tree

assets/built/screen.css

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

assets/built/screen.css.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

assets/css/screen.css

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2193,7 +2193,7 @@ html.dark-mode .post-card-image {
21932193
}
21942194

21952195
html.dark-mode :is(.post-card-tags, .post-card-meta, .article-tag a, .byline-meta-content, .pagination .page-number) {
2196-
color: color-mod(var(--color-secondary-text) l(-22%));
2196+
color: var(--color-secondary-text);
21972197
}
21982198

21992199
html.dark-mode .post-card-featured {
@@ -2387,7 +2387,7 @@ html.dark-mode .footer-cta-title {
23872387
}
23882388

23892389
html.auto-color :is(.post-card-tags, .post-card-meta, .article-tag a, .byline-meta-content, .pagination .page-number) {
2390-
color: color-mod(var(--color-secondary-text) l(-22%));
2390+
color: var(--color-secondary-text);
23912391
}
23922392

23932393
html.auto-color .post-card-featured {

0 commit comments

Comments
 (0)