Fixed member e2e routes after suite reshuffle

ref https://linear.app/ghost/issue/BER-3506/rework-feature-flagging-for-release

This finishes the members and members-legacy e2e split by moving stale React tests off members-forward and aligning detail navigation with the current members list UI.

Author: jonatansberg

e2e/helpers/pages/admin/members/members-list-page.ts

@@ -39,6 +39,14 @@ export class MembersListPage extends AdminPage {
         return this.memberRows.filter({hasText: name});
     }
 
+    getMemberLinkByName(name: string): Locator {
+        return this.getMemberByName(name).getByRole('link', {name, exact: true});
+    }
+
+    async openMemberByName(name: string): Promise<void> {
+        await this.getMemberLinkByName(name).click();
+    }
+
     async openActionsMenu(): Promise<void> {
         await this.actionsButton.click();
     }

e2e/tests/admin/members/list.test.ts

@@ -57,7 +57,7 @@ test.describe('Ghost Admin - Members List', () => {
         const membersPage = new MembersListPage(page);
         await membersPage.goto();
 
-        await membersPage.getMemberByName('Detail Test Member').click();
+        await membersPage.openMemberByName('Detail Test Member');
 
         await expect(page).toHaveURL(new RegExp(`/members/${member.id}`));
     });

e2e/tests/admin/members/saved-views.test.ts

@@ -15,7 +15,7 @@ async function addFilter(page: Page, filterName: 'Name' | 'Email' | 'Label', val
         const existingFilter = params.get('filter');
 
         params.set('filter', existingFilter ? `${existingFilter}+${labelFilter}` : labelFilter);
-        await page.goto(`/ghost/#/members-forward?${params.toString()}`);
+        await page.goto(`/ghost/#/members?${params.toString()}`);
         return;
     }
 

e2e/tests/admin/members/search-and-filter.test.ts

@@ -44,7 +44,7 @@ test.describe('Ghost Admin - Members Search and Filter', () => {
         await membersPage.goto();
         await expect(membersPage.memberRows).toHaveCount(3);
 
-        await page.goto('/ghost/#/members-forward?filter=label:VIP');
+        await page.goto('/ghost/#/members?filter=label:VIP');
         await expect(membersPage.memberRows).toHaveCount(2);
         await expect(membersPage.getMemberByName('Labelled One')).toBeVisible();
         await expect(membersPage.getMemberByName('Labelled Two')).toBeVisible();
@@ -65,7 +65,7 @@ test.describe('Ghost Admin - Members Search and Filter', () => {
         await membersPage.addFilter('Name', 'Alice');
         await expect(membersPage.memberRows).toHaveCount(2);
 
-        await page.goto('/ghost/#/members-forward?filter=name:~%27Alice%27%2Blabel:Premium');
+        await page.goto('/ghost/#/members?filter=name:~%27Alice%27%2Blabel:Premium');
         await expect(membersPage.memberRows).toHaveCount(1);
         await expect(membersPage.getMemberByName('Alice Alpha')).toBeVisible();
 
@@ -81,14 +81,14 @@ test.describe('Ghost Admin - Members Search and Filter', () => {
             {name: 'No Label', email: 'nolabel@example.com'}
         ]);
 
-        const membersPage = new MembersForwardPage(page);
+        const membersPage = new MembersListPage(page);
         await membersPage.goto();
         await expect(membersPage.memberRows).toHaveCount(4);
 
-        await page.goto('/ghost/#/members-forward?filter=label:VIP');
+        await page.goto('/ghost/#/members?filter=label:VIP');
         await expect(membersPage.memberRows).toHaveCount(2);
 
-        await page.goto('/ghost/#/members-forward?filter=label:VIP%2Blabel:Premium');
+        await page.goto('/ghost/#/members?filter=label:VIP%2Blabel:Premium');
         await expect(membersPage.memberRows).toHaveCount(1);
         await expect(membersPage.getMemberByName('Both Labels')).toBeVisible();
     });

e2e/tests/admin/members/virtual-window.test.ts

@@ -70,7 +70,7 @@ test.describe('Ghost Admin - Members Virtual Window', () => {
 
         await mockLargeMembersList(page, members);
 
-        const membersPage = new MembersPage(page, {route: 'members-forward'});
+        const membersPage = new MembersPage(page, {route: 'members'});
         const memberDetailsPage = new MemberDetailsPage(page);
 
         await membersPage.goto();
@@ -80,7 +80,7 @@ test.describe('Ghost Admin - Members Virtual Window', () => {
 
         await expect.poll(async () => {
             const historyState = await page.evaluate(() => window.history.state);
-            return historyState?.ghostVirtualListWindow?.['/members-forward::'];
+            return historyState?.ghostVirtualListWindow?.['/members::'];
         }).toBe(2000);
 
         const maxRenderedIndex = await membersPage.scrollUntilMaxRenderedIndexAtLeast(1000);
@@ -97,12 +97,12 @@ test.describe('Ghost Admin - Members Virtual Window', () => {
 
         expect(targetRow.index).toBeGreaterThan(1000);
 
-        await targetRowLocator.click();
+        await targetRowLocator.getByRole('link').click();
 
         await expect(memberDetailsPage.nameInput).toBeVisible();
 
         await page.goBack();
-        await expect(page).toHaveURL(/\/ghost\/#\/members-forward$/);
+        await expect(page).toHaveURL(/\/ghost\/#\/members$/);
         await expect(membersPage.getMemberListItemByIndex(targetRow.index)).toContainText(targetRow.text ?? '');
 
         await expect.poll(async () => {