Extracted gift-links side effects into ports

[rob-ghost]

Problem

The gift-links service bundled several unrelated concerns into one file — logging actions, mapping database rows, generating tokens, and the core read/write logic — which blurred the boundaries and made the service harder to follow.

Solution

Kept a single service but gave each concern its own home: action logging is now an injected dependency, row mapping and token generation moved out, and the schema definition was renamed for clarity. The slower database-backed service-level tests were replaced with faster unit tests plus end-to-end coverage of the not-found and concurrency behaviours.

[coderabbitai]

🚥 Pre-merge checks | ✅ 4

✅ Passed checks (4 passed)

Check name	Status	Explanation
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Title check	✅ Passed	The title matches the refactor theme and highlights extracted side effects, a central part of the change.
Description check	✅ Passed	The description is clearly about the gift-links refactor and extracted concerns, so it is related to the changeset.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch refactor/gift-links-cqrs

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[nx-cloud]

🤖 Nx Cloud AI Fix

Ensure the fix-ci command is configured to always run in your CI pipeline to get automatic fixes in future runs. For more information, please see https://nx.dev/ci/features/self-healing-ci

---

View your CI Pipeline Execution ↗ for commit 8897359

Command	Status	Duration	Result
nx run ghost:test:ci:integration	✅ Succeeded	2m 47s	View ↗
nx run ghost:test:integration	✅ Succeeded	2m 49s	View ↗
nx run ghost:test:legacy	✅ Succeeded	2m 50s	View ↗
nx run ghost:test:e2e	✅ Succeeded	2m 27s	View ↗
nx run-many --target=build --projects=tag:publi...	✅ Succeeded	<1s	View ↗
nx run-many -t test:unit -p ghost	✅ Succeeded	29s	View ↗
nx run @tryghost/admin:build	✅ Succeeded	9s	View ↗
nx run-many -t lint -p ghost	✅ Succeeded	33s	View ↗
Additional runs (2)	✅ Succeeded	...	View ↗

💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗

---

☁️ Nx Cloud last updated this comment at 2026-07-07 08:00:05 UTC

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@ghost/core/core/server/services/gift-links/commands.ts`:
- Around line 19-26: The `GiftLinksCommands.ensure()` flow is not atomic: it
checks `post.giftLinks` before the write path, while `mint()` merges on
`post_id`, so concurrent calls can mint different tokens and return one that is
later overwritten. Move the “no gift link exists” check into the transaction
used by `mint()`/the ensure path, and use an insert-or-lock strategy so only one
call can create the association. Make `ensure()` return the live association
created or observed in that transaction, and call `recordAction({context, verb:
'add', subject: postId})` only when this invocation actually created the link.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: c8a01828-04e2-4700-9f03-55892801828d

📥 Commits

Reviewing files that changed from the base of the PR and between 03bed4a and f4a20bc.

📒 Files selected for processing (19)

• ghost/core/core/frontend/services/proxy.js
• ghost/core/core/frontend/services/routing/controllers/entry/gift-links.ts
• ghost/core/core/server/api/endpoints/gift-links.ts
• ghost/core/core/server/api/endpoints/utils/serializers/output/gift-links.ts
• ghost/core/core/server/services/gift-links/actions.ts
• ghost/core/core/server/services/gift-links/codec.ts
• ghost/core/core/server/services/gift-links/commands.ts
• ghost/core/core/server/services/gift-links/index.ts
• ghost/core/core/server/services/gift-links/models.ts
• ghost/core/core/server/services/gift-links/queries.ts
• ghost/core/core/server/services/gift-links/schema.ts
• ghost/core/core/server/services/gift-links/serializers.ts
• ghost/core/core/server/services/gift-links/service.ts
• ghost/core/test/e2e-api/admin/gift-links.test.ts
• ghost/core/test/e2e-frontend/gift-links-toast-override.test.ts
• ghost/core/test/e2e-frontend/gift-links.test.ts
• ghost/core/test/integration/services/gift-links.test.ts
• ghost/core/test/unit/server/services/gift-links/actions.test.ts
• ghost/core/test/unit/server/services/gift-links/gift-link-token.test.ts

💤 Files with no reviewable changes (4)

• ghost/core/test/integration/services/gift-links.test.ts
• ghost/core/core/server/services/gift-links/serializers.ts
• ghost/core/core/server/services/gift-links/schema.ts
• ghost/core/core/server/services/gift-links/service.ts

[cursor]

Bugbot is not enabled for this team, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

[cursor]

Bugbot is not enabled for this team, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.