Skip to content

Removed @tryghost/i18n placeholder dev script from pnpm dev fan-out#28982

Merged
9larsons merged 1 commit into
mainfrom
drop-i18n-dev-placeholder
Jun 30, 2026
Merged

Removed @tryghost/i18n placeholder dev script from pnpm dev fan-out#28982
9larsons merged 1 commit into
mainfrom
drop-i18n-dev-placeholder

Conversation

@9larsons

Copy link
Copy Markdown
Contributor

Removed the dev script and its inline Nx target from ghost/i18n/package.json. The script was echo "Implement me!" — a never-filled scaffolding slot — but it was pulled into pnpm dev via the ^dev chain because the public apps depend on @tryghost/i18n.

Why it's safe

  • i18n locales are static JSON in ghost/i18n/locales/* — loaded by the Ghost backend at runtime, no build step.
  • The public-app UMDs (portal, comments-ui, signup-form, sodo-search, announcement-bar) bundle their own locales at build time via their own Vite configs — they import ghost/i18n/lib/i18n.js directly (visible in dev-server output) and don't depend on an i18n watcher.
  • Translation extraction is the translate script, not dev.

Verified

  • pnpm nx show project @tryghost/i18n no longer lists a dev target.
  • pnpm dev:daemon boots cleanly: 17 tasks fan out (was 18), no nx run @tryghost/i18n:dev line, no Implement me! line. Ghost backend up on :2368, admin Vite ready, all six public-app UMDs return 200 via Caddy at /ghost/assets/<app>/<app>.min.js.
  • pnpm --filter @tryghost/i18n test:base still green (100% coverage).

no ref

- the script printed 'Implement me!' and exited, but was pulled into pnpm dev
  via the ^dev chain because public apps depend on @tryghost/i18n
- i18n locales are static JSON loaded by Ghost at runtime and bundled into
  the public-app UMDs by their own vite builds; no watcher is needed
- dropping the script (and its inline nx target) removes one task from the
  17-task fan-out and the placeholder line from boot output
@coderabbitai

coderabbitai Bot commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 4592438b-2339-4fc0-9b54-0dadf5c497a8

📥 Commits

Reviewing files that changed from the base of the PR and between 5734a5d and 42dd654.

📒 Files selected for processing (1)
  • ghost/i18n/package.json

Walkthrough

In ghost/i18n/package.json, the scripts.dev entry (a placeholder echoing "Implement me!") is removed. The nx.targets block, which contained a dev target with continuous: true, is also removed, leaving the nx configuration with only the tags array.

Suggested reviewers

  • acburdine
🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed It clearly describes removing the placeholder i18n dev script from the pnpm dev task fan-out.
Description check ✅ Passed It matches the change by explaining the removed dev script, its Nx target, and why it was safe.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch drop-i18n-dev-placeholder

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@nx-cloud

nx-cloud Bot commented Jun 29, 2026

Copy link
Copy Markdown

🤖 Nx Cloud AI Fix

Ensure the fix-ci command is configured to always run in your CI pipeline to get automatic fixes in future runs. For more information, please see https://nx.dev/ci/features/self-healing-ci


View your CI Pipeline Execution ↗ for commit 42dd654

Command Status Duration Result
nx run @tryghost/admin-x-settings:test:acceptance ✅ Succeeded 10m 33s View ↗
nx run ghost:test:ci:integration ✅ Succeeded 2m 35s View ↗
nx run-many --target=build --projects=tag:publi... ✅ Succeeded 2s View ↗
nx run ghost:test:integration ✅ Succeeded 2m 2s View ↗
nx run-many -t test:unit -p @tryghost/admin-x-s... ✅ Succeeded 3m 39s View ↗
nx run ghost:test:legacy ✅ Succeeded 2m 58s View ↗
nx run ghost:test:e2e ✅ Succeeded 1m 52s View ↗
nx run @tryghost/admin:build ✅ Succeeded 1m 37s View ↗
Additional runs (5) ✅ Succeeded ... View ↗

💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗


☁️ Nx Cloud last updated this comment at 2026-06-29 23:47:17 UTC

@9larsons 9larsons marked this pull request as ready for review June 30, 2026 14:25
@9larsons 9larsons merged commit 543bf1f into main Jun 30, 2026
44 of 45 checks passed
@9larsons 9larsons deleted the drop-i18n-dev-placeholder branch June 30, 2026 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant