Removed @tryghost/i18n placeholder dev script from pnpm dev fan-out#28982
Conversation
no ref - the script printed 'Implement me!' and exited, but was pulled into pnpm dev via the ^dev chain because public apps depend on @tryghost/i18n - i18n locales are static JSON loaded by Ghost at runtime and bundled into the public-app UMDs by their own vite builds; no watcher is needed - dropping the script (and its inline nx target) removes one task from the 17-task fan-out and the placeholder line from boot output
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughIn Suggested reviewers
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
| Command | Status | Duration | Result |
|---|---|---|---|
nx run @tryghost/admin-x-settings:test:acceptance |
✅ Succeeded | 10m 33s | View ↗ |
nx run ghost:test:ci:integration |
✅ Succeeded | 2m 35s | View ↗ |
nx run-many --target=build --projects=tag:publi... |
✅ Succeeded | 2s | View ↗ |
nx run ghost:test:integration |
✅ Succeeded | 2m 2s | View ↗ |
nx run-many -t test:unit -p @tryghost/admin-x-s... |
✅ Succeeded | 3m 39s | View ↗ |
nx run ghost:test:legacy |
✅ Succeeded | 2m 58s | View ↗ |
nx run ghost:test:e2e |
✅ Succeeded | 1m 52s | View ↗ |
nx run @tryghost/admin:build |
✅ Succeeded | 1m 37s | View ↗ |
Additional runs (5) |
✅ Succeeded | ... | View ↗ |
💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗
☁️ Nx Cloud last updated this comment at 2026-06-29 23:47:17 UTC

Removed the
devscript and its inline Nx target fromghost/i18n/package.json. The script wasecho "Implement me!"— a never-filled scaffolding slot — but it was pulled intopnpm devvia the^devchain because the public apps depend on@tryghost/i18n.Why it's safe
ghost/i18n/locales/*— loaded by the Ghost backend at runtime, no build step.portal,comments-ui,signup-form,sodo-search,announcement-bar) bundle their own locales at build time via their own Vite configs — they importghost/i18n/lib/i18n.jsdirectly (visible in dev-server output) and don't depend on an i18n watcher.translatescript, notdev.Verified
pnpm nx show project @tryghost/i18nno longer lists adevtarget.pnpm dev:daemonboots cleanly: 17 tasks fan out (was 18), nonx run @tryghost/i18n:devline, noImplement me!line. Ghost backend up on:2368, admin Vite ready, all six public-app UMDs return 200 via Caddy at/ghost/assets/<app>/<app>.min.js.pnpm --filter @tryghost/i18n test:basestill green (100% coverage).