Skip to content

Cleaned up stale references to the removed posts and stats apps#29327

Merged
9larsons merged 1 commit into
mainfrom
slars/post-dissolution-doc-sweep
Jul 14, 2026
Merged

Cleaned up stale references to the removed posts and stats apps#29327
9larsons merged 1 commit into
mainfrom
slars/post-dissolution-doc-sweep

Conversation

@9larsons

@9larsons 9larsons commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

ref https://linear.app/ghost/issue/PLA-246/

The posts/stats packages dissolved into apps/admin domain folders, but a number of docs and code comments still pointed at the deleted apps/posts/apps/stats paths — including AGENTS.md directing new admin features to apps/posts.

Comment/doc-only; no behavior change.

  • AGENTS.md — admin-apps inventory, koenig-lexical consumers, the Tailwind @source lists (now matching apps/admin/src/index.css), and the "where to build new admin features" guidance
  • docker/dev-gateway/README.md — served-apps note
  • vitest.config.mjs — watch-filter example + a sentence about the long-gone admin-x-activitypub directory
  • configs/eslint-react/index.mjs@example header named a deleted config file; made generic
  • ghost/core .../schema/views.js — cross-reference to the member subscription-resolution consumer, now at apps/admin/src/members/member-query-params.ts (and no longer a getCurrentSubscription helper)
  • automations email utils (8 files) — the duplicated-file NOTEs pointed at the deleted posts copies; they now point at the real counterpart in the other app so the keep-in-sync constraint survives
  • apps/admin/src/routes.tsx — dropped a comment narrating the dissolved PostsAppContext
  • shared-views.ts ×2 — dropped TODOs whose "once the apps are merged" premise is satisfied (the layout hook already delegates to the members parser)
  • shade-page-templates skill — trigger list/glob no longer names posts/stats

Deliberately left: apps/shade's posts-stats transitional subpath and the docs describing it — that subpath still exists and is removed separately.

Verification

  • eslint clean on all touched JS/TS files (also enforced by lint-staged on commit)
  • grep -rn 'apps/posts\|apps/stats' across the repo now only matches the intentionally-kept shade posts-stats files

ref https://linear.app/ghost/issue/PLA-246/post-dissolution-sweep-stale-docs-comments-referencing-appsposts-and

- docs and comments still pointed at apps/posts and apps/stats after those
  packages dissolved into apps/admin domain folders — AGENTS.md even directed
  new admin features to apps/posts
- updated the duplicated-file NOTEs in the automations email utils to point at
  their real admin-x-settings/apps-admin counterparts so the keep-in-sync
  constraint survives
- dropped the shared-views TODOs whose "once the apps are merged" premise is
  satisfied (the layout hook already delegates to the members parser)
- comment/doc-only; no behavior change
@github-actions github-actions Bot added the migration [pull request] Includes migration for review label Jul 14, 2026
@github-actions

Copy link
Copy Markdown
Contributor

It looks like this PR contains a migration 👀
Here's the checklist for reviewing migrations:

General requirements

  • ⚠️ Tested performance on staging database servers, as performance on local machines is not comparable to a production environment
  • Satisfies idempotency requirement (both up() and down())
  • Does not reference models
  • Filename is in the correct format (and correctly ordered)
  • Targets the next minor version
  • All code paths have appropriate log messages
  • Uses the correct utils
  • Contains a minimal changeset
  • Does not mix DDL/DML operations
  • Tested in MySQL and SQLite

Schema changes

  • Both schema change and related migration have been implemented
  • For index changes: has been performance tested for large tables
  • For new tables/columns: fields use the appropriate predefined field lengths
  • For new tables/columns: field names follow the appropriate conventions
  • Does not drop a non-alpha table outside of a major version

Data changes

  • Mass updates/inserts are batched appropriately
  • Does not loop over large tables/datasets
  • Defends against missing or invalid data
  • For settings updates: follows the appropriate guidelines

@coderabbitai

coderabbitai Bot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Walkthrough

Updated repository guidance and documentation to reflect the consolidated Admin React shell and its admin-x-settings and activitypub embedded apps. Adjusted Shade trigger paths, Tailwind source references, development gateway notes, Koenig import guidance, and Admin UI development instructions. Updated duplicated email helper comments to reference current locations, removed obsolete TODO and refactor comments, and refreshed supporting references in ESLint, schema, and Vitest documentation.

Possibly related PRs

  • TryGhost/Ghost#28960: Both changes update the shade-page-templates skill and its autoTrigger scope.
  • TryGhost/Ghost#29213: Both changes touch useSharedViews in apps/admin/src/layout/app-sidebar/shared-views.ts.
🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title matches the PR’s main theme of removing stale posts/stats references and is specific enough for history scanning.
Description check ✅ Passed The description accurately summarizes the doc/comment cleanup and matches the files and intent in the changeset.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch slars/post-dissolution-doc-sweep

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@nx-cloud

nx-cloud Bot commented Jul 14, 2026

Copy link
Copy Markdown

🤖 Nx Cloud AI Fix

Ensure the fix-ci command is configured to always run in your CI pipeline to get automatic fixes in future runs. For more information, please see https://nx.dev/ci/features/self-healing-ci


View your CI Pipeline Execution ↗ for commit 3400a71

Command Status Duration Result
nx run @tryghost/admin-x-settings:test:acceptance ✅ Succeeded 10m 13s View ↗
nx run-many --target=build --projects=tag:publi... ✅ Succeeded 1s View ↗
nx run-many -t test:unit -p @tryghost/adapter-b... ✅ Succeeded 7m 59s View ↗
nx run ghost:test:ci:integration ✅ Succeeded 2m 41s View ↗
nx run ghost:test:integration ✅ Succeeded 2m 53s View ↗
nx run @tryghost/admin:build ✅ Succeeded 3m 8s View ↗
nx run ghost-monorepo:lint:boundaries ✅ Succeeded 7s View ↗
nx run ghost:test:legacy ✅ Succeeded 2m 50s View ↗
Additional runs (9) ✅ Succeeded ... View ↗

💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗


☁️ Nx Cloud last updated this comment at 2026-07-14 19:21:20 UTC

@9larsons
9larsons enabled auto-merge (squash) July 14, 2026 19:11
@9larsons
9larsons disabled auto-merge July 14, 2026 19:11
@9larsons
9larsons enabled auto-merge (squash) July 14, 2026 19:11
@codecov

codecov Bot commented Jul 14, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.95%. Comparing base (4a64c91) to head (3400a71).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #29327      +/-   ##
==========================================
- Coverage   73.95%   73.95%   -0.01%     
==========================================
  Files        1579     1579              
  Lines      136893   136893              
  Branches    16570    16569       -1     
==========================================
- Hits       101244   101242       -2     
+ Misses      34640    34609      -31     
- Partials     1009     1042      +33     
Flag Coverage Δ
admin-tests 55.31% <ø> (ø)
e2e-tests 76.04% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@9larsons
9larsons merged commit b64c0cb into main Jul 14, 2026
52 checks passed
@9larsons
9larsons deleted the slars/post-dissolution-doc-sweep branch July 14, 2026 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

migration [pull request] Includes migration for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant