Skip to content

Downgraded ElasticSearch to version 8#590

Merged
9larsons merged 1 commit intomainfrom
elasticsearch-8
Apr 27, 2026
Merged

Downgraded ElasticSearch to version 8#590
9larsons merged 1 commit intomainfrom
elasticsearch-8

Conversation

@sam-lord
Copy link
Copy Markdown
Contributor

ref INC-275

Added a test to ensure that the major version of ElasticSearch is the one that we're currently using in production, and won't be accidentally updated by renovate.

ref [INC-275](https://app.incident.io/ghost/incidents/275)

Added a test to ensure that the major version of ElasticSearch is the
one that we're currently using in production, and won't be
accidentally updated by renovate.
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 27, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 5b975a75-157d-44ab-a121-7a8b093a1c14

📥 Commits

Reviewing files that changed from the base of the PR and between 2507e15 and c839e85.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (2)
  • packages/elasticsearch/package.json
  • packages/elasticsearch/test/ElasticSearch.test.js

Walkthrough

The pull request downgrades the @elastic/elasticsearch dependency from version 9.3.4 to 8.19.1 in the package.json, and adds a runtime test that verifies the installed Elasticsearch package has a major version of 8. The test reads the dependency's package.json, extracts the major version number, and asserts it matches the expected value with a descriptive failure message.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: downgrading the Elasticsearch package from version 9.3.4 to 8.19.1, which is the primary modification in the pull request.
Description check ✅ Passed The description is directly related to the changeset, explaining the purpose of adding a test to ensure the Elasticsearch major version remains at the production version and won't be accidentally upgraded.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch elasticsearch-8

Comment @coderabbitai help to get the list of available commands and usage tips.

@sam-lord sam-lord requested a review from 9larsons April 27, 2026 13:27
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.10%. Comparing base (2507e15) to head (c839e85).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #590   +/-   ##
=======================================
  Coverage   98.10%   98.10%           
=======================================
  Files          84       84           
  Lines        2737     2737           
  Branches      503      503           
=======================================
  Hits         2685     2685           
  Misses         11       11           
  Partials       41       41           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Collaborator

@9larsons 9larsons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also added a rule to tryghost/renovate-config for this.

@9larsons 9larsons merged commit d8df93c into main Apr 27, 2026
4 checks passed
@9larsons 9larsons deleted the elasticsearch-8 branch April 27, 2026 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants